Refactored the DeviceManagementService to get its parameters from a delegate.

chrome/browser/policy/browser_policy_connector.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/policy/browser_policy_connector.h"
 
 #include <algorithm>
 #include <iterator>
 
 #include "base/bind.h"
@@ skipping 104 matching lines @@
     return base::FilePath();
 
   CFStringRef bundle_id = CFBundleGetIdentifier(bundle);
   if (!bundle_id)
     return base::FilePath();
 
   return path.Append(base::SysCFStringRefToUTF8(bundle_id) + ".plist");
 }
 #endif  // defined(OS_MACOSX) && !defined(OS_IOS)
 
-std::string GetDeviceManagementUrl() {
-  CommandLine* command_line = CommandLine::ForCurrentProcess();
-  if (command_line->HasSwitch(switches::kDeviceManagementUrl))
-    return command_line->GetSwitchValueASCII(switches::kDeviceManagementUrl);
-  else
-    return kDefaultDeviceManagementServerUrl;
-}
+class DeviceManagementServiceConfiguration
+    : public DeviceManagementService::Configuration {
+ public:
+  DeviceManagementServiceConfiguration() {}
+  virtual ~DeviceManagementServiceConfiguration() {}
 
-std::string GetUserAgentParameter() {
-  chrome::VersionInfo version_info;
-  return base::StringPrintf("%s %s(%s)",
-                            version_info.Name().c_str(),
-                            version_info.Version().c_str(),
-                            version_info.LastChange().c_str());
-}
+  virtual std::string GetServerUrl() OVERRIDE {
+    CommandLine* command_line = CommandLine::ForCurrentProcess();
+    if (command_line->HasSwitch(switches::kDeviceManagementUrl))
+      return command_line->GetSwitchValueASCII(switches::kDeviceManagementUrl);
+    else
+      return kDefaultDeviceManagementServerUrl;
+  }
 
-std::string GetPlatformParameter() {
-  std::string os_name = base::SysInfo::OperatingSystemName();
-  std::string os_hardware = base::SysInfo::OperatingSystemArchitecture();
+  virtual std::string GetUserAgent() OVERRIDE {
+    return content::GetUserAgent(GURL(GetServerUrl()));
+  }
+
+  virtual std::string GetAgentParameter() OVERRIDE {
+    chrome::VersionInfo version_info;
+    return base::StringPrintf("%s %s(%s)",
+                              version_info.Name().c_str(),
+                              version_info.Version().c_str(),
+                              version_info.LastChange().c_str());
+  }
+
+  virtual std::string GetPlatformParameter() OVERRIDE {
+    std::string os_name = base::SysInfo::OperatingSystemName();
+    std::string os_hardware = base::SysInfo::OperatingSystemArchitecture();
 
 #if defined(OS_CHROMEOS)
-  chromeos::system::StatisticsProvider* provider =
-      chromeos::system::StatisticsProvider::GetInstance();
+    chromeos::system::StatisticsProvider* provider =
+        chromeos::system::StatisticsProvider::GetInstance();
 
-  std::string hwclass;
-  if (!provider->GetMachineStatistic(chromeos::system::kHardwareClass,
-                                     &hwclass)) {
-    LOG(ERROR) << "Failed to get machine information";
-  }
-  os_name += ",CrOS," + base::SysInfo::GetLsbReleaseBoard();
-  os_hardware += "," + hwclass;
+    std::string hwclass;
+    if (!provider->GetMachineStatistic(chromeos::system::kHardwareClass,
+                                       &hwclass)) {
+      LOG(ERROR) << "Failed to get machine information";
+    }
+    os_name += ",CrOS," + base::SysInfo::GetLsbReleaseBoard();
+    os_hardware += "," + hwclass;
 #endif
 
-  std::string os_version("-");
+    std::string os_version("-");
 #if defined(OS_WIN) || defined(OS_MACOSX) || defined(OS_CHROMEOS)
-  int32 os_major_version = 0;
-  int32 os_minor_version = 0;
-  int32 os_bugfix_version = 0;
-  base::SysInfo::OperatingSystemVersionNumbers(&os_major_version,
-                                               &os_minor_version,
-                                               &os_bugfix_version);
-  os_version = base::StringPrintf("%d.%d.%d",
-                                  os_major_version,
-                                  os_minor_version,
-                                  os_bugfix_version);
+    int32 os_major_version = 0;
+    int32 os_minor_version = 0;
+    int32 os_bugfix_version = 0;
+    base::SysInfo::OperatingSystemVersionNumbers(&os_major_version,
+                                                 &os_minor_version,
+                                                 &os_bugfix_version);
+    os_version = base::StringPrintf("%d.%d.%d",
+                                    os_major_version,
+                                    os_minor_version,
+                                    os_bugfix_version);
 #endif
 
-  return base::StringPrintf(
-      "%s|%s|%s", os_name.c_str(), os_hardware.c_str(), os_version.c_str());
-}
+    return base::StringPrintf(
+        "%s|%s|%s", os_name.c_str(), os_hardware.c_str(), os_version.c_str());
+  }
+};
 
 }  // namespace
 
 BrowserPolicyConnector::BrowserPolicyConnector()
     : is_initialized_(false),
       local_state_(NULL),
       weak_ptr_factory_(this) {
   // GetPolicyService() must be ready after the constructor is done.
   // The connector is created very early during startup, when the browser
   // threads aren't running yet; initialize components that need local_state,
@@ skipping 44 matching lines @@
     PrefService* local_state,
     scoped_refptr<net::URLRequestContextGetter> request_context) {
   // Initialization of some of the providers requires the FILE thread; make
   // sure that threading is ready at this point.
   DCHECK(BrowserThread::IsThreadInitialized(BrowserThread::FILE));
   DCHECK(!is_initialized()) << "BrowserPolicyConnector::Init() called twice.";
 
   local_state_ = local_state;
   request_context_ = request_context;
 
-  std::string server_url = GetDeviceManagementUrl();
+  scoped_ptr<DeviceManagementService::Configuration> configuration(
+      new DeviceManagementServiceConfiguration);
   device_management_service_.reset(
-      new DeviceManagementService(request_context,
-                                  server_url,
-                                  content::GetUserAgent(GURL(server_url)),
-                                  GetUserAgentParameter(),
-                                  GetPlatformParameter()));
+      new DeviceManagementService(configuration.Pass(), request_context));
   device_management_service_->ScheduleInitialization(
       kServiceInitializationStartupDelay);
 
   if (g_testing_provider)
     g_testing_provider->Init();
   if (platform_provider_)
     platform_provider_->Init();
 
 #if defined(OS_CHROMEOS)
   global_user_cloud_policy_provider_.Init();
@@ skipping 294 matching lines @@
     return new AsyncPolicyProvider(loader.Pass());
   } else {
     return NULL;
   }
 #else
   return NULL;
 #endif
 }
 
 }  // namespace policy