Refactored the DeviceManagementService to get its parameters from a delegate.

chrome/browser/policy/cloud/device_management_service_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <ostream>
 #include <vector>
 
 #include "base/bind.h"
 #include "base/message_loop/message_loop.h"
 #include "base/message_loop/message_loop_proxy.h"
 #include "base/run_loop.h"
 #include "base/strings/string_split.h"
 #include "chrome/browser/policy/cloud/cloud_policy_constants.h"
 #include "chrome/browser/policy/cloud/device_management_service.h"
+#include "chrome/browser/policy/cloud/mock_device_management_service.h"
 #include "net/base/escape.h"
 #include "net/base/load_flags.h"
 #include "net/base/net_errors.h"
 #include "net/http/http_response_headers.h"
 #include "net/url_request/test_url_fetcher_factory.h"
 #include "net/url_request/url_request_status.h"
 #include "net/url_request/url_request_test_util.h"
 #include "testing/gmock/include/gmock/gmock.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 using testing::Mock;
 using testing::_;
 
 namespace em = enterprise_management;
 
 namespace policy {
 
 const char kServiceUrl[] = "https://example.com/management_service";
-const char kUserAgent[] = "Chrome 1.2.3(456)";
-const char kPlatform[] = "Test|Unit|1.2.3";
 
 // Encoded empty response messages for testing the error code paths.
 const char kResponseEmpty[] = "\x08\x00";
 
 #define PROTO_STRING(name) (std::string(name, arraysize(name) - 1))
 
 // Some helper constants.
 const char kGaiaAuthToken[] = "gaia-auth-token";
 const char kOAuthToken[] = "oauth-token";
 const char kDMToken[] = "device-management-token";
@@ skipping 11 matching lines @@
     ResetService();
     InitializeService();
   }
 
   ~DeviceManagementServiceTestBase() {
     service_.reset();
     base::RunLoop().RunUntilIdle();
   }
 
   void ResetService() {
-    service_.reset(new DeviceManagementService(
-        request_context_,
-        kServiceUrl,
-        kUserAgent,
-        kUserAgent,
-        kPlatform));
+    scoped_ptr<DeviceManagementService::Configuration> configuration(
+        new MockDeviceManagementServiceConfiguration(kServiceUrl));
+    service_.reset(
+        new DeviceManagementService(configuration.Pass(), request_context_));
   }
 
   void InitializeService() {
     service_->ScheduleInitialization(0);
     base::RunLoop().RunUntilIdle();
   }
 
   net::TestURLFetcher* GetFetcher() {
     return factory_.GetFetcherByID(DeviceManagementService::kURLFetcherID);
   }
@@ skipping 612 matching lines @@
   EXPECT_CALL(*this, OnJobDone(DM_STATUS_REQUEST_FAILED, _, _));
   EXPECT_CALL(*this, OnJobRetry(_)).Times(0);
   fetcher->set_status(net::URLRequestStatus(net::URLRequestStatus::FAILED,
                                             net::ERR_NETWORK_CHANGED));
   fetcher->set_url(GURL(kServiceUrl));
   fetcher->delegate()->OnURLFetchComplete(fetcher);
   Mock::VerifyAndClearExpectations(this);
 }
 
 }  // namespace policy