Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Unified Diff: third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js

Issue 2568983003: Add ability to linkify substituted string
Patch Set: Comments addressed Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js
diff --git a/third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js b/third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js
index 6e467f36fd244e285c071d2f3ab2f9371491a3e8..fa74380337d62827d66eb6f79543269cfab0ad11 100644
--- a/third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js
+++ b/third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js
@@ -973,7 +973,9 @@ Console.ConsoleView = class extends UI.VBox {
if (this._currentMatchRangeIndex >= 0) {
matchRange = this._regexMatchRanges[this._currentMatchRangeIndex];
var message = this._visibleViewMessages[matchRange.messageIndex];
- message.searchHighlightNode(matchRange.matchIndex).classList.remove(UI.highlightedCurrentSearchResultClassName);
+ message.searchHighlightNodes(matchRange.matchIndex).forEach(node => {
+ node.classList.remove(UI.highlightedCurrentSearchResultClassName);
+ });
}
index = mod(index, this._regexMatchRanges.length);
@@ -981,10 +983,12 @@ Console.ConsoleView = class extends UI.VBox {
this._searchableView.updateCurrentMatchIndex(index);
matchRange = this._regexMatchRanges[index];
var message = this._visibleViewMessages[matchRange.messageIndex];
- var highlightNode = message.searchHighlightNode(matchRange.matchIndex);
- highlightNode.classList.add(UI.highlightedCurrentSearchResultClassName);
+ var highlightNodes = message.searchHighlightNodes(matchRange.matchIndex);
+ highlightNodes.forEach((node, idx) => {
+ node.classList.add(UI.highlightedCurrentSearchResultClassName);
+ });
this._viewport.scrollItemIntoView(matchRange.messageIndex);
- highlightNode.scrollIntoViewIfNeeded();
+ highlightNodes[0].scrollIntoViewIfNeeded();
}
_updateStickToBottomOnMouseDown() {

Powered by Google App Engine
This is Rietveld 408576698