third_party/WebKit/LayoutTests/inspector/console/console-log-linkify-links.html - Issue 2568983003: Add ability to linkify substituted string

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/inspector/console/console-log-linkify-links.html

Issue 2568983003: Add ability to linkify substituted string

Patch Set: Comments addressed Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/inspector/console/console-format-style.html ('k') | third_party/WebKit/Source/devtools/front_end/components/Linkifier.js » ('j') | third_party/WebKit/Source/devtools/front_end/components/Linkifier.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <html>	1 <html>

2 <head>	2 <head>

3 <script src="../../http/tests/inspector/inspector-test.js"></script>	3 <script src="../../http/tests/inspector/inspector-test.js"></script>

4 <script src="../../http/tests/inspector/console-test.js"></script>	4 <script src="../../http/tests/inspector/console-test.js"></script>

5 <script>	5 <script>

6 console.log("http://www.chromium.org/");	6 console.log("http://www.chromium.org/");

7 console.log("follow http://www.chromium.org/");	7 console.log("follow http://www.chromium.org/");

8 console.log("string", "http://www.chromium.org/");	8 console.log("string", "http://www.chromium.org/");

9 console.log(123, "http://www.chromium.org/");	9 console.log(123, "http://www.chromium.org/");

10 console.log("http://www.chromium.org/some?v=114:56:57");	10 console.log("http://www.chromium.org/some?v=114:56:57");

11	11 console.log("%s%s %s%s", "http", "://www.fb.com", "http", "://google.com");

	12 console.log('www.%s.or%sww.google.com','chromium', 'g w');

12	13

13 function test()	14 function test()

14 {	15 {

15 InspectorTest.dumpConsoleMessages(false, true);	16 InspectorTest.dumpConsoleMessages(false, true);

16	17

17 InspectorTest.addResult("Dump urls in messages");	18 InspectorTest.addResult("Dump urls in messages");

18 var consoleView = Console.ConsoleView.instance();	19 var consoleView = Console.ConsoleView.instance();

19 var viewMessages = consoleView._visibleViewMessages;	20 var viewMessages = consoleView._visibleViewMessages;

20 for (var i = 0; i < viewMessages.length; ++i) {	21 for (var i = 0; i < viewMessages.length; ++i) {

21 var uiMessage = viewMessages[i];	22 var uiMessage = viewMessages[i];

22 var element = uiMessage.contentElement();	23 var element = uiMessage.contentElement();

23 var links = element.querySelectorAll(".devtools-link");	24 var links = element.querySelectorAll(".devtools-link");

24 for (var link of links) {	25 for (var link of links) {

25 var info = Components.Linkifier._linkInfo(link);	26 var info = Components.Linkifier._linkInfo(link);

26 InspectorTest.addResult("linked url:" + (info && info.url));	27 InspectorTest.addResult("linked url:" + (info && info.url));

27 }	28 }

28 }	29 }

29	30

30 InspectorTest.completeTest();	31 InspectorTest.completeTest();

31 }	32 }

32 </script>	33 </script>

33 </head>	34 </head>

34 <body onload="runTest()">	35 <body onload="runTest()">

35 <p>	36 <p>

36 Test that console.log() would linkify the links. <a href="http://crbug.com/23107 4">Bug 231074.</a>	37 Test that console.log() would linkify the links. <a href="http://crbug.com/23107 4">Bug 231074.</a>

37 </p>	38 </p>

38 </body>	39 </body>

39 </html>	40 </html>

OLD	NEW