third_party/WebKit/LayoutTests/inspector/console/console-format-linkify.html - Issue 2568983003: Add ability to linkify substituted string

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/inspector/console/console-format-linkify.html

Issue 2568983003: Add ability to linkify substituted string

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « AUTHORS ('k') | third_party/WebKit/LayoutTests/inspector/console/console-format-style.html » ('j') | third_party/WebKit/Source/devtools/front_end/components/Linkifier.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <html>	1 <html>

2 <head>	2 <head>

3 <script src="../../http/tests/inspector/inspector-test.js"></script>	3 <script src="../../http/tests/inspector/inspector-test.js"></script>

4 <script src="../../http/tests/inspector/console-test.js"></script>	4 <script src="../../http/tests/inspector/console-test.js"></script>

5 <script>	5 <script>

6 function onload()	6 function onload()

7 {	7 {

8 console.log("%cBlue!.", "color: blue;");	8 console.log("%chttp://%cwww.google.com%c:%d%c/%c:123%c:456", "color:lightgra y", "color:blue", "color:orange", 80, "color:lightgray", "color:green", "color:r ed", 12)

9 console.log("%cBlue! %cRed!", "color: blue;", "color: red;");	9 console.log("%cwww.%s", "color:lightgray", "google.com", 12)
	luoe 2016/12/13 00:08:27 This case passes, but a similar case does not: con This case passes, but a similar case does not: console.log("%cwww.%s 12", "color:lightgray", "google.com") Can we have a plain test case here too? console.log("%cwww.google.com", "color: blue"); karabur 2016/12/14 17:32:50 Yes, this is same case as @pfeldman noted, current Show quoted text On 2016/12/13 at 00:08:27, luoe wrote: > This case passes, but a similar case does not: > console.log("%cwww.%s 12", "color:lightgray", "google.com") Yes, this is same case as @pfeldman noted, currently parts of string does not get linkified if there are substitutions in that parts. I'll figure out how to do that. Show quoted text > Can we have a plain test case here too? > console.log("%cwww.google.com", "color: blue"); sure
10 console.log("%cwww.google.com", "color: blue");

11 runTest();	10 runTest();

12 }	11 }

13	12

14 function test()	13 function test()

15 {	14 {

16 InspectorTest.expandConsoleMessages(onExpanded);	15 InspectorTest.expandConsoleMessages(onExpanded);

17	16

18 function onExpanded()	17 function onExpanded()

19 {	18 {

20 InspectorTest.dumpConsoleMessagesWithStyles();	19 InspectorTest.dumpConsoleMessagesWithStyles();

21 InspectorTest.completeTest();	20 InspectorTest.completeTest();

22 }	21 }

23 }	22 }

24 </script>	23 </script>

25 </head>	24 </head>

26	25

27 <body onload="onload()">	26 <body onload="onload()">

28 <p>Tests that console logging dumps properly styled messages.</p>	27 <p>Tests that console logging dumps properly styled messages.</p>

29 </body>	28 </body>

30 </html>	29 </html>

OLD	NEW