Cleanup: Remove unused resources in ui_strings.grd or mark them as platform-specific.

Cleanup: Remove unused resources in ui_strings.grd or mark them as platform-specific.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266463

[Jun Mukai, 2014-04-25 22:02:03]

Great!

LGTM for the message center change with a nit comment.
I don't know IDS_APP_UNTITLED_SHORTCUT_FILE_NAME though.

https://codereview.chromium.org/256893002/diff/1/ui/base/strings/ui_strings.grd
File ui/base/strings/ui_strings.grd (right):

https://codereview.chromium.org/256893002/diff/1/ui/base/strings/ui_strings.g...
ui/base/strings/ui_strings.grd:2159: <if expr="use_ash or chromeos">
screenshot is actually chromeos only.

A message is referred in chrome/browser/ui/ash/screenshot_taker.cc, but actually
the 'CreateNotification' method is called only from a clause of #if
defined(OS_CHROMEOS)

This is not your fault but could you edit screenshot_taker.cc so that the
message is referred only in ChromeOS?  Then you can use expr="chromeos"

[Lei Zhang, 2014-04-25 22:15:56]

ok, see patch set 2.

[Jun Mukai, 2014-04-25 22:17:19]

lgtm

looks better to me

[Lei Zhang, 2014-04-25 22:17:44]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2014-04-25 22:28:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thestig@chromium.org/256893002/20001

[commit-bot: I haz the power, 2014-04-26 00:26:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-26 00:26:14]

Try jobs failed on following builders:
  tryserver.chromium on win_chromium_rel

[Lei Zhang, 2014-04-26 00:29:05]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2014-04-26 00:31:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thestig@chromium.org/256893002/20001

[commit-bot: I haz the power, 2014-04-26 03:59:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-26 03:59:28]

Try jobs failed on following builders:
  tryserver.chromium on linux_chromium_chromeos_rel

[Lei Zhang, 2014-04-26 04:03:38]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2014-04-26 04:05:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thestig@chromium.org/256893002/20001

[commit-bot: I haz the power, 2014-04-26 06:34:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-26 06:34:01]

Try jobs failed on following builders:
  tryserver.chromium on win_chromium_rel

[Lei Zhang, 2014-04-26 16:49:32]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2014-04-26 16:50:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thestig@chromium.org/256893002/20001

[commit-bot: I haz the power, 2014-04-28 07:09:13]

Change committed as 266463