Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Unified Diff: third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationControllerImpl.h

Issue 2568913003: Remove DOMWindowProperty from ScreenOrientationCoontroller (Closed)
Patch Set: temp Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationControllerImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationControllerImpl.h
diff --git a/third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationControllerImpl.h b/third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationControllerImpl.h
index 837d2c9338be0d87e14589fd73ead4fb49b5dd22..7fa43739595eaf9d9e51b4430536e86706052535 100644
--- a/third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationControllerImpl.h
+++ b/third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationControllerImpl.h
@@ -5,7 +5,7 @@
#ifndef ScreenOrientationControllerImpl_h
#define ScreenOrientationControllerImpl_h
-#include "core/frame/DOMWindowProperty.h"
+#include "core/dom/Document.h"
#include "core/frame/PlatformEventController.h"
#include "core/frame/ScreenOrientationController.h"
#include "modules/ModulesExport.h"
@@ -23,7 +23,7 @@ class WebScreenOrientationClient;
class MODULES_EXPORT ScreenOrientationControllerImpl final
: public GarbageCollectedFinalized<ScreenOrientationControllerImpl>,
public ScreenOrientationController,
- public DOMWindowProperty,
+ public ContextLifecycleObserver,
public PlatformEventController {
USING_GARBAGE_COLLECTED_MIXIN(ScreenOrientationControllerImpl);
WTF_MAKE_NONCOPYABLE(ScreenOrientationControllerImpl);
@@ -57,8 +57,8 @@ class MODULES_EXPORT ScreenOrientationControllerImpl final
bool hasLastData() override;
void pageVisibilityChanged() override;
- // Inherited from DOMWindowProperty.
- void frameDestroyed() override;
+ // Inherited from ContextLifecycleObserver.
+ void contextDestroyed() override;
void notifyDispatcher();
« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationControllerImpl.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698