PDF viewer: Specify tabId when navigating with chrome.tabs.update.

chrome/browser/pdf/pdf_extension_test.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stddef.h>
 
 #include <vector>
 
 #include "base/base_paths.h"
 #include "base/files/file_enumerator.h"
@@ skipping 887 matching lines @@
   const GURL& url = active_web_contents->GetURL();
   ASSERT_EQ(std::string("http://www.example.com/"), url.spec());
 }
 
 // Test that if the plugin tries to load a URL that redirects then it will fail
 // to load. This is to avoid the source origin of the document changing during
 // the redirect, which can have security implications. https://crbug.com/653749.
 IN_PROC_BROWSER_TEST_F(PDFExtensionTest, RedirectsFailInPlugin) {
   RunTestsInFile("redirects_fail_test.js", "test.pdf");
 }
+
+IN_PROC_BROWSER_TEST_F(PDFExtensionTest, NavigationOnCorrectTab) {

[raymes, 2016/12/14 01:43:28]

nit: You may want to link to the bug above here and note that this makes sure
that even if a different tab is selected when a navigation occurs, the correct
tab still gets navigated.

[Kevin McNee, 2016/12/14 16:03:33]

Done.

+  GURL test_pdf_url(embedded_test_server()->GetURL("/pdf/test.pdf"));
+  content::WebContents* guest_contents = LoadPdfGetGuestContents(test_pdf_url);
+  ASSERT_TRUE(guest_contents);
+  content::WebContents* web_contents =
+      browser()->tab_strip_model()->GetActiveWebContents();
+
+  ui_test_utils::NavigateToURLWithDisposition(
+      browser(), GURL("about:blank"),
+      WindowOpenDisposition::NEW_FOREGROUND_TAB,
+      ui_test_utils::BROWSER_TEST_WAIT_FOR_TAB |
+          ui_test_utils::BROWSER_TEST_WAIT_FOR_NAVIGATION);
+  content::WebContents* active_web_contents =
+      browser()->tab_strip_model()->GetActiveWebContents();

[raymes, 2016/12/14 01:43:28]

nit: may want to assert that active_web_contents is not equal to web_contents

[Kevin McNee, 2016/12/14 16:03:33]

Done.

+
+  ASSERT_TRUE(content::ExecuteScript(
+      guest_contents,
+      "var navMessage = new MessageEvent("
+      "    'message',"
+      "    {"
+      "      data: {"
+      "        type: 'navigate',"
+      "        url: 'www.example.com',"
+      "        disposition: Navigator.WindowOpenDisposition.CURRENT_TAB"
+      "      }"
+      "    });"
+      "var plugin = document.getElementsByTagName('embed')[0];"
+      "plugin.dispatchEvent(navMessage);"));

[raymes, 2016/12/14 01:43:28]

nit: I was thinking we could just fire the navigate event on the document. On
second thought, I think we can just call viewer.navigator_.navigate(uri,
disposition)

[Kevin McNee, 2016/12/14 16:03:33]

Done.

+
+  EXPECT_TRUE(web_contents->GetController().GetPendingEntry());
+  EXPECT_FALSE(active_web_contents->GetController().GetPendingEntry());
+}