Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Unified Diff: components/cronet/ios/cronet_environment.mm

Issue 2568883002: [cronet] Add member for QUIC user agent ID, with getter and setter. (Closed)
Patch Set: fix tangled cl Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cronet/ios/cronet_environment.mm
diff --git a/components/cronet/ios/cronet_environment.mm b/components/cronet/ios/cronet_environment.mm
index 62c8407aa863134ef03416e4a4c95733e2582e29..40defa199fbbf9d5a5354c3b930e777d46c21cd5 100644
--- a/components/cronet/ios/cronet_environment.mm
+++ b/components/cronet/ios/cronet_environment.mm
@@ -213,6 +213,7 @@ CronetEnvironment::CronetEnvironment(const std::string& user_agent,
bool user_agent_partial)
: http2_enabled_(false),
quic_enabled_(false),
+ quic_user_agent_id_(""),
mef 2016/12/12 21:52:20 std::string is initialized to empty string by defa
lilyhoughton 2016/12/13 15:10:22 Done.
user_agent_(user_agent),
user_agent_partial_(user_agent_partial),
net_log_(new net::NetLog) {}
@@ -271,7 +272,7 @@ void CronetEnvironment::InitializeOnNetworkThread() {
std::unique_ptr<URLRequestContextConfig> config(new URLRequestContextConfig(
quic_enabled_, // Enable QUIC.
- "", // QUIC User Agent ID.
+ quic_user_agent_id_, // QUIC User Agent ID.
mef 2016/12/12 21:52:20 could call getDefault... here if |quic_user_agent_
lilyhoughton 2016/12/13 15:10:22 It should also check if |quic_enabled_| is true, t
mef 2016/12/13 20:46:43 Yes, good point.
http2_enabled_, // Enable SPDY.
false, // Enable SDCH
URLRequestContextConfig::DISK, // Type of http cache.
« components/cronet/ios/cronet_environment.h ('K') | « components/cronet/ios/cronet_environment.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698