Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Unified Diff: third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.idl

Issue 2568743009: Fix low risk trivial non-nullable =>nullable idl mismatch in WebGL2RenderingContextBase.idl (Closed)
Patch Set: Revert change made to readPixels Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.idl
diff --git a/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.idl b/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.idl
index 45c6d0d72c4f368e4e04ec5717e7931da491cccd..1a1bc79eac24b16570c7a1704eb54839bd4c6c17 100644
--- a/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.idl
+++ b/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.idl
@@ -391,7 +391,7 @@ typedef unsigned long long GLuint64;
void clearBufferfi(GLenum buffer, GLint drawbuffer, GLfloat depth, GLint stencil);
/* Query Objects */
- WebGLQuery createQuery();
+ WebGLQuery? createQuery();
void deleteQuery(WebGLQuery? query);
GLboolean isQuery(WebGLQuery? query);
void beginQuery(GLenum target, WebGLQuery query);
@@ -400,7 +400,7 @@ typedef unsigned long long GLuint64;
[CallWith=ScriptState] any getQueryParameter(WebGLQuery query, GLenum pname);
/* Sampler Objects */
- WebGLSampler createSampler();
+ WebGLSampler? createSampler();
void deleteSampler(WebGLSampler? sampler);
GLboolean isSampler(WebGLSampler? sampler);
void bindSampler(GLuint unit, WebGLSampler? sampler);
@@ -409,7 +409,7 @@ typedef unsigned long long GLuint64;
[CallWith=ScriptState] any getSamplerParameter(WebGLSampler sampler, GLenum pname);
/* Sync objects */
- WebGLSync fenceSync(GLenum condition, GLbitfield flags);
+ WebGLSync? fenceSync(GLenum condition, GLbitfield flags);
GLboolean isSync(WebGLSync? sync);
void deleteSync(WebGLSync? sync);
GLenum clientWaitSync(WebGLSync sync, GLbitfield flags, GLuint64 timeout);
@@ -418,14 +418,14 @@ typedef unsigned long long GLuint64;
[CallWith=ScriptState] any getSyncParameter(WebGLSync sync, GLenum pname);
/* Transform Feedback */
- WebGLTransformFeedback createTransformFeedback();
+ WebGLTransformFeedback? createTransformFeedback();
void deleteTransformFeedback(WebGLTransformFeedback? feedback);
GLboolean isTransformFeedback(WebGLTransformFeedback? feedback);
void bindTransformFeedback(GLenum target, WebGLTransformFeedback? feedback);
void beginTransformFeedback(GLenum primitiveMode);
void endTransformFeedback();
void transformFeedbackVaryings(WebGLProgram program, sequence<DOMString> varyings, GLenum bufferMode);
- WebGLActiveInfo getTransformFeedbackVarying(WebGLProgram program, GLuint index);
+ WebGLActiveInfo? getTransformFeedbackVarying(WebGLProgram program, GLuint index);
void pauseTransformFeedback();
void resumeTransformFeedback();
@@ -441,7 +441,7 @@ typedef unsigned long long GLuint64;
void uniformBlockBinding(WebGLProgram program, GLuint uniformBlockIndex, GLuint uniformBlockBinding);
/* Vertex Array Objects */
- WebGLVertexArrayObject createVertexArray();
+ WebGLVertexArrayObject? createVertexArray();
void deleteVertexArray(WebGLVertexArrayObject? vertexArray);
GLboolean isVertexArray(WebGLVertexArrayObject? vertexArray);
void bindVertexArray(WebGLVertexArrayObject? vertexArray);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698