Fix analyzer's SDK detection so that during integration tests, we use the built SDK.

Fix analyzer's SDK detection so that during integration tests, we use the built SDK.

R=scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/fb2dbfce21023a0d807d08315350f2c588a54184

[Paul Berry, 2016-12-12 17:36:17]

paulberry@google.com changed reviewers:
+ brianwilkerson@google.com, scheglov@google.com

[scheglov, 2016-12-12 17:43:03]

LGTM

[Paul Berry, 2016-12-12 17:49:55]

Description was changed from

==========
Fix analyzer's SDK detection so that during integration tests, we use the built
SDK.
==========

to

==========
Fix analyzer's SDK detection so that during integration tests, we use the built
SDK.

R=scheglov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/fb2dbfce21023a0d807d08315350f2c588a54184
==========

[Paul Berry, 2016-12-12 17:49:56]

Committed patchset #1 (id:1) manually as
fb2dbfce21023a0d807d08315350f2c588a54184 (presubmit successful).

[Brian Wilkerson, 2016-12-12 17:59:59]

lgtm

[zra, 2016-12-12 19:16:17]

zra@google.com changed reviewers:
+ zra@google.com

[zra, 2016-12-12 19:16:18]

https://codereview.chromium.org/2568743003/diff/1/pkg/analyzer/lib/src/dart/s...
File pkg/analyzer/lib/src/dart/sdk/sdk.dart (right):

https://codereview.chromium.org/2568743003/diff/1/pkg/analyzer/lib/src/dart/s...
pkg/analyzer/lib/src/dart/sdk/sdk.dart:706: if
(resourceProvider.getFolder(sdkPath).exists) {
Shouldn't this be checking the existence of buildSdkPath rather than sdkPath?
This is probably what is causing the build failure.

[Paul Berry, 2016-12-12 19:24:39]

https://codereview.chromium.org/2568743003/diff/1/pkg/analyzer/lib/src/dart/s...
File pkg/analyzer/lib/src/dart/sdk/sdk.dart (right):

https://codereview.chromium.org/2568743003/diff/1/pkg/analyzer/lib/src/dart/s...
pkg/analyzer/lib/src/dart/sdk/sdk.dart:706: if
(resourceProvider.getFolder(sdkPath).exists) {
On 2016/12/12 19:16:17, zra wrote:
> Shouldn't this be checking the existence of buildSdkPath rather than sdkPath?
> This is probably what is causing the build failure.

Yes, I just noticed this as well.  Thanks.

[Paul Berry, 2016-12-12 19:27:50]

https://codereview.chromium.org/2568743003/diff/1/pkg/analyzer/lib/src/dart/s...
File pkg/analyzer/lib/src/dart/sdk/sdk.dart (right):

https://codereview.chromium.org/2568743003/diff/1/pkg/analyzer/lib/src/dart/s...
pkg/analyzer/lib/src/dart/sdk/sdk.dart:706: if
(resourceProvider.getFolder(sdkPath).exists) {
On 2016/12/12 19:24:39, Paul Berry wrote:
> On 2016/12/12 19:16:17, zra wrote:
> > Shouldn't this be checking the existence of buildSdkPath rather than
sdkPath?
> > This is probably what is causing the build failure.
> 
> Yes, I just noticed this as well.  Thanks.

Fix is here: https://codereview.chromium.org/2568253002/