Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(512)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2568723007: Create Namer and Emitter on codegen start. (Closed)

Created:
4 years ago by Johnni Winther
Modified:
4 years ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : A few more #

Patch Set 3 : Small fix. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+257 lines, -160 lines) Patch
M pkg/compiler/lib/src/common/backend_api.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/compiler.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend.dart View 7 chunks +20 lines, -13 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/field_naming_mixin.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/frequency_namer.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/js_backend/minify_namer.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/js_backend/namer.dart View 11 chunks +23 lines, -29 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/class_stub_generator.dart View 5 chunks +14 lines, -10 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/code_emitter_task.dart View 4 chunks +42 lines, -22 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/full_emitter/class_emitter.dart View 1 chunk +6 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/full_emitter/code_emitter_helper.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/full_emitter/emitter.dart View 6 chunks +40 lines, -13 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/full_emitter/interceptor_emitter.dart View 3 chunks +5 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/full_emitter/nsm_emitter.dart View 1 3 chunks +7 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/interceptor_stub_generator.dart View 2 chunks +5 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/js_emitter.dart View 1 chunk +3 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/lazy_emitter/emitter.dart View 2 chunks +17 lines, -8 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/parameter_stub_generator.dart View 2 chunks +4 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/program_builder/collector.dart View 1 4 chunks +6 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/program_builder/field_visitor.dart View 1 3 chunks +4 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart View 1 2 11 chunks +23 lines, -16 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/startup_emitter/emitter.dart View 2 chunks +22 lines, -8 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/type_test_registry.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M pkg/dart2js_incremental/lib/caching_compiler.dart View 1 chunk +0 lines, -10 lines 0 comments Download
M tests/compiler/dart2js/type_representation_test.dart View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Johnni Winther
4 years ago (2016-12-13 15:23:29 UTC) #2
Johnni Winther
ping
4 years ago (2016-12-14 09:01:09 UTC) #3
Siggi Cherem (dart-lang)
lgtm
4 years ago (2016-12-15 19:15:03 UTC) #4
Johnni Winther
4 years ago (2016-12-16 09:11:05 UTC) #6
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
254bea33946db1206726aafbfa85df8246484d11 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698