Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 2568723002: Change the way tasks are registered (Closed)

Created:
4 years ago by Brian Wilkerson
Modified:
4 years ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -119 lines) Patch
M pkg/analyzer/lib/plugin/task.dart View 1 chunk +0 lines, -14 lines 0 comments Download
M pkg/analyzer/lib/src/generated/engine.dart View 3 chunks +88 lines, -7 lines 0 comments Download
M pkg/analyzer/lib/src/plugin/engine_plugin.dart View 7 chunks +0 lines, -98 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
A first step toward removing the engine plugin.
4 years ago (2016-12-11 18:59:35 UTC) #2
scheglov
LGTM
4 years ago (2016-12-11 19:14:55 UTC) #3
Brian Wilkerson
4 years ago (2016-12-11 19:25:36 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
84577c55bb0b4955983ac2ce3a3b30a1b5d46ab4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698