Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(595)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/common/system/executive.py

Issue 2568703003: Update comment about SIGINT on Windows in Executive. (Closed)
Patch Set: Update comment about SIGINT on Windows in Executive. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Tools/Scripts/webkitpy/common/system/executive.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/common/system/executive.py b/third_party/WebKit/Tools/Scripts/webkitpy/common/system/executive.py
index 492eb45de15a334b45a059f6b243c8bcf3aaba60..30c3a8c744eb902d4c7b7e4180700a0e932a06e8 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/common/system/executive.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/common/system/executive.py
@@ -292,8 +292,9 @@ class Executive(object):
def interrupt(self, pid):
interrupt_signal = signal.SIGINT
- # FIXME: The python docs seem to imply that platform == 'win32' may need to use signal.CTRL_C_EVENT
- # http://docs.python.org/2/library/signal.html
+ # Note: The python docs seem to suggest that on Windows, we may want to use
+ # signal.CTRL_C_EVENT (http://docs.python.org/2/library/signal.html), but
+ # it appears that signal.SIGINT also appears to work on Windows.
try:
os.kill(pid, interrupt_signal)
except OSError:
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698