LayoutTests/fast/multicol/vertical-lr/break-properties.html - Issue 25687002: Add support for the column-fill property.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/multicol/vertical-lr/break-properties.html

Issue 25687002: Add support for the column-fill property. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Put changes to problematic files (for the bots) back in. Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/fast/multicol/unsplittable-inline-block.html ('k') | LayoutTests/fast/multicol/vertical-lr/column-count-with-rules.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <style>	1 <style>

2 div.box { -webkit-box-sizing: border; border: solid blue; }	2 div.box { -webkit-box-sizing: border; border: solid blue; }

3 div.shorter { width: 54px; }	3 div.shorter { width: 54px; }

4 div.taller { width: 72px; }	4 div.taller { width: 72px; }

5 </style>	5 </style>

6 <body style="-webkit-writing-mode:vertical-lr">	6 <body style="-webkit-writing-mode:vertical-lr">

7 <div style="width: 100px; height: 630px; -webkit-column-gap: 5px; -webkit-column s: 6;">	7 <div style="width:100px; height:630px; -webkit-columns:6; -webkit-column-gap:5px ; columns:6; column-gap:5px; column-fill:auto;">

8 <div class="taller box"></div>	8 <div class="taller box"></div>

9 <div class="taller box"></div>	9 <div class="taller box"></div>

10 <div id="break-before" class="shorter box" style="-webkit-column-break-befor e: always;"></div>	10 <div id="break-before" class="shorter box" style="-webkit-column-break-befor e: always;"></div>

11 <div class="shorter box" style="-webkit-column-break-after: always;"></div>	11 <div class="shorter box" style="-webkit-column-break-after: always;"></div>

12 <div id="after-break" class="shorter box"></div>	12 <div id="after-break" class="shorter box"></div>

13 <div id="no-break" class="shorter box" style="-webkit-column-break-inside: a void;"></div>	13 <div id="no-break" class="shorter box" style="-webkit-column-break-inside: a void;"></div>

14 </div>	14 </div>

15 <pre id="console"></pre>	15 <pre id="console"></pre>

16 <script>	16 <script>

17 if (window.testRunner)	17 if (window.testRunner)

18 testRunner.dumpAsText();	18 testRunner.dumpAsText();

19	19

20 function log(message)	20 function log(message)

21 {	21 {

22 document.getElementById("console").appendChild(document.createTextNode(m essage + "\n"));	22 document.getElementById("console").appendChild(document.createTextNode(m essage + "\n"));

23 }	23 }

24	24

25 function testBoxPosition(id, expectedLeft, expectedTop)	25 function testBoxPosition(id, expectedLeft, expectedTop)

26 {	26 {

27 var rect = document.getElementById(id).getBoundingClientRect();	27 var rect = document.getElementById(id).getBoundingClientRect();

28 if (Math.round(rect.left) === expectedLeft && Math.round(rect.top) === e xpectedTop)	28 if (Math.round(rect.left) === expectedLeft && Math.round(rect.top) === e xpectedTop)

29 log("PASS: '" + id + "' is at (" + expectedLeft + ", " + expectedTop + ")");	29 log("PASS: '" + id + "' is at (" + expectedLeft + ", " + expectedTop + ")");

30 else	30 else

31 log("FAIL: '" + id + "' is at (" + Math.round(rect.left) + ", " + Ma th.round(rect.top) + ") instead of (" + expectedLeft + " ," + expectedTop + ")") ;	31 log("FAIL: '" + id + "' is at (" + Math.round(rect.left) + ", " + Ma th.round(rect.top) + ") instead of (" + expectedLeft + " ," + expectedTop + ")") ;

32 }	32 }

33	33

34 testBoxPosition("break-before", 8, 220);	34 testBoxPosition("break-before", 8, 220);

35 testBoxPosition("after-break", 8, 431);	35 testBoxPosition("after-break", 8, 431);

36 </script>	36 </script>

OLD	NEW