LayoutTests/fast/multicol/hit-test-end-of-column-with-line-height.html - Issue 25687002: Add support for the column-fill property.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/multicol/hit-test-end-of-column-with-line-height.html

Issue 25687002: Add support for the column-fill property. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Put changes to problematic files (for the bots) back in. Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <div id="target" style="	2 <div id="target" style="

3 outline: dashed lightblue;	3 outline: dashed lightblue;

4 width: 400px;

5 -webkit-columns: 2;	4 -webkit-columns: 2;

6 -webkit-column-gap: 0;	5 -webkit-column-gap: 0;

	6 columns: 2;

	7 column-gap: 0;

	8 column-fill: auto;

	9 width: 400px;

7 height: 80px;	10 height: 80px;

8 font: 20px ahem;	11 font: 20px ahem;

9 line-height: 2;	12 line-height: 2;

10 ">Lorem ipsum dolor sit amet</div>	13 ">Lorem ipsum dolor sit amet</div>

11 <pre id="console"></pre>	14 <pre id="console"></pre>

12 <script>	15 <script>

13 if (window.testRunner)	16 if (window.testRunner)

14 testRunner.dumpAsText();	17 testRunner.dumpAsText();

15	18

16 function log(message)	19 function log(message)

(...skipping 16 matching lines...) Expand all Loading...
33	36

34 // Clicking above the last line in the first column should not select anythi ng from the first	37 // Clicking above the last line in the first column should not select anythi ng from the first

35 // line on the second column.	38 // line on the second column.

36 hitOffset = document.caretRangeFromPoint(target.offsetLeft + 190, target.off setTop + 3).startOffset;	39 hitOffset = document.caretRangeFromPoint(target.offsetLeft + 190, target.off setTop + 3).startOffset;

37 log(hitOffset === 11 ? "PASS" : "FAIL: hit offset " + hitOffset + ".");	40 log(hitOffset === 11 ? "PASS" : "FAIL: hit offset " + hitOffset + ".");

38	41

39 // Clicking below the first line in the second column should not snap to the beginning of the line.	42 // Clicking below the first line in the second column should not snap to the beginning of the line.

40 hitOffset = document.caretRangeFromPoint(target.offsetLeft + 250, target.off setTop + 78).startOffset;	43 hitOffset = document.caretRangeFromPoint(target.offsetLeft + 250, target.off setTop + 78).startOffset;

41 log(hitOffset === 14 ? "PASS" : "FAIL: hit offset " + hitOffset + ".");	44 log(hitOffset === 14 ? "PASS" : "FAIL: hit offset " + hitOffset + ".");

42 </script>	45 </script>

OLD	NEW

« no previous file with comments | « LayoutTests/fast/multicol/hit-test-end-of-column.html ('k') | LayoutTests/fast/multicol/hit-test-float.html » ('j') | no next file with comments »