Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 #!/usr/bin/python | 1 #!/usr/bin/python |
| 2 # Copyright (C) 2010 Google Inc. All rights reserved. | 2 # Copyright (C) 2010 Google Inc. All rights reserved. |
| 3 # | 3 # |
| 4 # Redistribution and use in source and binary forms, with or without | 4 # Redistribution and use in source and binary forms, with or without |
| 5 # modification, are permitted provided that the following conditions | 5 # modification, are permitted provided that the following conditions |
| 6 # are met: | 6 # are met: |
| 7 # 1. Redistributions of source code must retain the above copyright | 7 # 1. Redistributions of source code must retain the above copyright |
| 8 # notice, this list of conditions and the following disclaimer. | 8 # notice, this list of conditions and the following disclaimer. |
| 9 # 2. Redistributions in binary form must reproduce the above copyright | 9 # 2. Redistributions in binary form must reproduce the above copyright |
| 10 # notice, this list of conditions and the following disclaimer in the | 10 # notice, this list of conditions and the following disclaimer in the |
| 11 # documentation and/or other materials provided with the distribution. | 11 # documentation and/or other materials provided with the distribution. |
| 12 # | 12 # |
| 13 # THIS SOFTWARE IS PROVIDED BY APPLE COMPUTER, INC. ``AS IS'' AND ANY | 13 # THIS SOFTWARE IS PROVIDED BY APPLE COMPUTER, INC. ``AS IS'' AND ANY |
| 14 # EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE | 14 # EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE |
| 15 # IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR | 15 # IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR |
| 16 # PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE COMPUTER, INC. OR | 16 # PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE COMPUTER, INC. OR |
| 17 # CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, | 17 # CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, |
| 18 # EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, | 18 # EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, |
| 19 # PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR | 19 # PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR |
| 20 # PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY | 20 # PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY |
| 21 # OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT | 21 # OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT |
| 22 # (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE | 22 # (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE |
| 23 # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. | 23 # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. |
| 24 # | 24 # |
| 25 | 25 |
| 26 import sys | 26 import sys |
| 27 | 27 |
| 28 from webkitpy.bindings.bindings_tests import run_bindings_tests | 28 from webkitpy.bindings.bindings_tests import run_bindings_tests |
| 29 from webkitpy.common import webkit_finder | |
| 30 webkit_finder.add_typ_dir_to_sys_path() | |
| 29 | 31 |
| 32 import typ | |
| 30 | 33 |
| 31 def main(argv): | 34 def main(argv): |
| 32 """Runs Blink bindings IDL compiler on test IDL files and compares the | 35 """Runs Blink bindings IDL compiler on test IDL files and compares the |
| 33 results with reference files. | 36 results with reference files. |
| 34 | 37 |
| 35 Please execute the script whenever changes are made to the compiler | 38 Please execute the script whenever changes are made to the compiler |
| 36 (this is automatically done as a presubmit script), | 39 (this is automatically done as a presubmit script), |
| 37 and submit changes to the test results in the same patch. | 40 and submit changes to the test results in the same patch. |
| 38 This makes it easier to track and review changes in generated code. | 41 This makes it easier to track and review changes in generated code. |
| 42 """ | |
| 43 argument_parser = typ.ArgumentParser() | |
|
peria
2016/12/12 04:43:10
optional:
I prefer to put a routine to parse optio
dglazkov
2016/12/12 05:08:22
SG, I'll think of a way to break it up better.
| |
| 44 argument_parser.add_argument('--reset-results', | |
| 45 default=False, | |
| 46 action='store_true', | |
| 47 help='Overwrites reference files with the generated results.') | |
| 48 argument_parser.add_argument('--skip-unit-tests', | |
| 49 default=False, | |
| 50 action='store_true', | |
| 51 help='Skip running unit tests (only run reference tests).') | |
| 52 argument_parser.add_argument('--skip-reference-tests', | |
| 53 default=False, | |
| 54 action='store_true', | |
| 55 help='Skip running reference tests (only run unit tests).') | |
| 39 | 56 |
| 40 Options: | 57 # First, run bindings unit tests. |
|
peria
2016/12/12 04:43:10
Why don't you use typ.main() as you did in https:/
dglazkov
2016/12/12 05:08:22
Ah, turns out, I can't. I need to effectively brea
| |
| 41 --reset-results: Overwrites reference files with the generated results. | 58 runner = typ.Runner() |
| 42 --verbose: Show output on success and logging messages (not just failure) | 59 runner.parse_args(argument_parser, argv[1:]) |
| 43 """ | 60 args = runner.args |
| 44 reset_results = '--reset-results' in argv | 61 if argument_parser.exit_status is not None: |
| 45 verbose = '--verbose' in argv | 62 return argument_parser.exit_status |
| 63 runner.args.top_level_dir = webkit_finder.get_bindings_scripts_dir() | |
| 64 if not args.skip_unit_tests: | |
| 65 return_code, _, _ = runner.run() | |
| 66 if return_code != 0: | |
| 67 return return_code | |
| 46 | 68 |
| 47 return run_bindings_tests(reset_results, verbose) | 69 if args.skip_reference_tests: |
| 70 return 0 | |
| 71 | |
| 72 # Now run the bindings end-to-end tests. | |
| 73 return run_bindings_tests(args.reset_results, args.verbose) | |
| 48 | 74 |
| 49 | 75 |
| 50 if __name__ == '__main__': | 76 if __name__ == '__main__': |
| 51 sys.exit(main(sys.argv)) | 77 sys.exit(main(sys.argv)) |
| OLD | NEW |