Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(930)

Unified Diff: components/offline_pages/core/background/cleanup_task.cc

Issue 2568613002: Reconcile the request queue on startup. (Closed)
Patch Set: compile fix Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/core/background/cleanup_task.cc
diff --git a/components/offline_pages/core/background/cleanup_task.cc b/components/offline_pages/core/background/cleanup_task.cc
index ab02e4f0ee278e4aae3abc972632347143cf251b..84e2a7864d4c24f9c466899da980bcd411166657 100644
--- a/components/offline_pages/core/background/cleanup_task.cc
+++ b/components/offline_pages/core/background/cleanup_task.cc
@@ -88,11 +88,6 @@ void CleanupTask::GetExpiredRequestIds(
OfflinerPolicyUtils::CheckRequestExpirationStatus(request.get(),
policy_);
- // TODO(petewil): The strategy of checking the state below relies on a
- // reconciliation task, so at startup we convert any OFFLINING requests to
- // AVAILABLE. Otherwise, requests in the OFFLINING state when chromium dies
- // will never be cleaned up.
-
// If we are not working on this request in an offliner, and it is not
// valid, put it on a list for removal. We make the exception for current
// requests because the request might expire after being chosen and before
« no previous file with comments | « components/offline_pages/core/background/BUILD.gn ('k') | components/offline_pages/core/background/reconcile_task.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698