Reconcile the request queue on startup.

components/offline_pages/core/background/request_coordinator.cc

Index: components/offline_pages/core/background/request_coordinator.cc
diff --git a/components/offline_pages/core/background/request_coordinator.cc b/components/offline_pages/core/background/request_coordinator.cc
index 79b0de0e78ac7f279eadd8e0ad8689dee9d7cb74..37129079a804f3e01256dee69c2f2811770224bd 100644
--- a/components/offline_pages/core/background/request_coordinator.cc
+++ b/components/offline_pages/core/background/request_coordinator.cc
@@ -184,7 +184,11 @@ RequestCoordinator::RequestCoordinator(
   std::unique_ptr<CleanupTaskFactory> cleanup_factory(
       new CleanupTaskFactory(policy_.get(), this, &event_logger_));
   queue_->SetCleanupFactory(std::move(cleanup_factory));
-  // Do a cleanup at startup time.
+  // If we exited with any items left in the OFFLINING state, move them

[fgorski, 2016/12/12 17:35:18]

I think order between reconcile and clean up makes sense, but please document it
in a comment as well.

Did you consider the opposite order? Why did you choose that one?

[Pete Williamson, 2016/12/15 18:37:43]

Both orders should work fine.  I picked this one because cleanup will ignore
OFFLINING requests, and in the case the request expired or exceeded a retry
count while offlining, I thought it best to clean it up sooner instead of later.
(comment added)

+  // back to the AVAILABLE state, and update the UI by sending notifications.
+  queue_->ReconcileRequests(base::Bind(&RequestCoordinator::ReconcileCallback,
+                                       weak_ptr_factory_.GetWeakPtr()));
+  // Do a cleanup of expired or over tried requests at startup time.
   queue_->CleanupRequestQueue();
 }
 
@@ -466,6 +470,12 @@ void RequestCoordinator::UpdateMultipleRequestsCallback(
     StartImmediatelyIfConnected();
 }
 
+void RequestCoordinator::ReconcileCallback(
+    std::unique_ptr<UpdateRequestsResult> result) {
+  for (const auto& request : result->updated_items)
+    NotifyChanged(request);
+}
+
 void RequestCoordinator::HandleRemovedRequestsAndCallback(
     const RemoveRequestsCallback& callback,
     RequestNotifier::BackgroundSavePageResult status,