Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 25686011: Unflake cctest/test-cpu-profiler/JsNativeJsRuntimeJsSample on Win32 Debug (Closed)

Created:
7 years, 2 months ago by yurys
Modified:
7 years, 2 months ago
CC:
v8-dev
Visibility:
Public.

Description

Unflake cctest/test-cpu-profiler/JsNativeJsRuntimeJsSample on Win32 Debug Profiler is now started from JavaScript. Since we always capture stack trace when starting profiler there should always be at least one expected sample in the profile. Also changed ProfilerEventsProcessor::AddCurrentStack to make sure it call TickSample::Init to instead of custom initialization code. BUG=v8:2920 R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=17140

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -18 lines) Patch
M src/cpu-profiler.cc View 1 chunk +8 lines, -7 lines 0 comments Download
M test/cctest/test-cpu-profiler.cc View 12 chunks +40 lines, -11 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
yurys
7 years, 2 months ago (2013-10-04 13:16:28 UTC) #1
yurys
7 years, 2 months ago (2013-10-04 13:17:54 UTC) #2
yurys
ping
7 years, 2 months ago (2013-10-08 16:43:44 UTC) #3
Jakob Kummerow
LGTM. If this successfully eliminates flakiness, the next step is to update test/cctest/cctest.status, but we ...
7 years, 2 months ago (2013-10-10 08:52:40 UTC) #4
yurys
Committed patchset #1 manually as r17140 (presubmit successful).
7 years, 2 months ago (2013-10-10 13:03:51 UTC) #5
yurys
7 years, 2 months ago (2013-10-10 13:06:23 UTC) #6
Message was sent while issue was closed.
On 2013/10/10 08:52:40, Jakob wrote:
> LGTM.
> 
> If this successfully eliminates flakiness, the next step is to update
> test/cctest/cctest.status, but we can leave that for now and watch the bots
for
> a few days.

Let's watch the tree for a few days and I'll remove custom expectations after
that.

Powered by Google App Engine
This is Rietveld 408576698