MD Settings: Internet: Only show detailed info for primary user.

chrome/browser/resources/settings/internet_page/internet_detail_page.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview
  * 'settings-internet-detail' is the settings subpage containing details
  * for a network.
  */
 (function() {
@@ skipping 19 matching lines @@
       type: Object,
       observer: 'networkPropertiesChanged_',
     },
 
     /** Preferences state. */
     prefs: {
       type: Object,
       notify: true,
     },
 
+    /** Email address for the primary user when user is a secondary user. */
+    primaryUserEmail_: {
+      type: String,
+      value: function() {
+        return loadTimeData.getBoolean('isSecondaryUser') ?
+            loadTimeData.getString('primaryUserEmail') : '';
+      },
+    },
+
     /**
      * Highest priority connected network or null.
      * @type {?CrOnc.NetworkStateProperties}
      */
     defaultNetwork: {
       type: Object,
       value: null,
     },
 
     /**
@@ skipping 150 matching lines @@
     if (networkIds.indexOf(this.guid) != -1)
       this.getNetworkDetails_();
   },
 
   /**
    * Calls networkingPrivate.getProperties for this.guid.
    * @private
    */
   getNetworkDetails_: function() {
     assert(!!this.guid);
-    this.networkingPrivate.getManagedProperties(
-        this.guid, this.getPropertiesCallback_.bind(this));
+    if (this.isSecondaryUser_()) {
+      this.networkingPrivate.getState(
+          this.guid, this.getStateCallback_.bind(this));
+    } else {
+      this.networkingPrivate.getManagedProperties(
+          this.guid, this.getPropertiesCallback_.bind(this));
+    }
   },
 
   /**
    * networkingPrivate.getProperties callback.
    * @param {CrOnc.NetworkProperties} properties The network properties.
    * @private
    */
   getPropertiesCallback_: function(properties) {
     this.networkProperties = properties;
     if (!properties) {
       // If |properties| becomes null (i.e. the network is no longer visible),
       // close the page.
       console.error('Network no longer exists: ' + this.guid);
       this.close_();
     }
   },
 
   /**
+   * networkingPrivate.getProperties callback.

[michaelpg, 2016/12/12 23:17:00]

getState

[stevenjb, 2016/12/13 00:57:55]

Done.

+   * @param {CrOnc.NetworkStateProperties} state The network state properties.
+   * @private
+   */
+  getStateCallback_: function(state) {
+    if (!state) {
+      // If |properties| becomes null (i.e. the network is no longer visible),

[michaelpg, 2016/12/12 23:17:00]

|state|?

[stevenjb, 2016/12/13 00:57:55]

Done.

+      // close the page.
+      console.error('Network no longer exists: ' + this.guid);
+      this.networkProperties = undefined;
+      this.close_();
+    }
+    this.networkProperties = {
+      GUID: state.GUID,
+      Type: state.Type,
+      Connectable: state.Connectable,
+      ConnectionState: state.ConnectionState,
+    };
+  },
+
+  /**
    * @param {!chrome.networkingPrivate.NetworkConfigProperties} onc The ONC
    *     network properties.
    * @private
    */
   setNetworkProperties_: function(onc) {
     assert(!!this.guid);
     this.networkingPrivate.setProperties(this.guid, onc, function() {
       if (chrome.runtime.lastError) {
         // An error typically indicates invalid input; request the properties
         // to update any invalid fields.
@@ skipping 23 matching lines @@
   /**
    * @return {boolean} True if the network is connected.
    * @private
    */
   isConnectedState_: function() {
     return this.networkProperties.ConnectionState ==
         CrOnc.ConnectionState.CONNECTED;
   },
 
   /**
+   * @return {boolean} True if settings are for a secondary user.
+   * @private
+   */
+  isSecondaryUser_: function() {
+    return !!this.primaryUserEmail_;

[michaelpg, 2016/12/12 23:17:00]

Can we use loadTimeData.getBoolean('isSecondaryUser'), maybe as its own
property? isSecondaryUser_ never changes, so we shouldn't have to set up all the
event listeners and such that Polymer would create for this binding.

Also, primaryUserEmail_ might not be set properly in situations like CrOS on
Linux or tests, maybe.

[stevenjb, 2016/12/13 00:57:55]

In that case I may as well make this a property, which is probably simpler
anyway. Done.

+  },
+
+  /**
    * @return {boolean}
    * @private
    */
   isRemembered_: function() {
     var source = this.networkProperties.Source;
     return !!source && source != CrOnc.Source.NONE;
   },
 
   /**
    * @return {boolean}
@@ skipping 480 matching lines @@
    */
   allPropertiesMatch_: function(curValue, newValue) {
     for (let key in newValue) {
       if (newValue[key] != curValue[key])
         return false;
     }
     return true;
   }
 });
 })();