Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1276)

Unified Diff: content/renderer/render_thread_impl.cc

Issue 2568543002: Fix data race in RenderThreadImplBrowserTest (Closed)
Patch Set: . Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/render_thread_impl.h ('k') | content/renderer/render_thread_impl_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_thread_impl.cc
diff --git a/content/renderer/render_thread_impl.cc b/content/renderer/render_thread_impl.cc
index b62a03139265e6689af06e13acf6bdcfa257f4a9..e3aee0fd6f46bee0e35485858d28fcbd722ddfcf 100644
--- a/content/renderer/render_thread_impl.cc
+++ b/content/renderer/render_thread_impl.cc
@@ -600,7 +600,7 @@ void RenderThreadImpl::SetRenderMessageFilterForTesting(
RenderThreadImpl::RenderThreadImpl(
const InProcessChildThreadParams& params,
std::unique_ptr<blink::scheduler::RendererScheduler> scheduler,
- scoped_refptr<base::SingleThreadTaskRunner>& resource_task_queue)
+ const scoped_refptr<base::SingleThreadTaskRunner>& resource_task_queue)
: ChildThreadImpl(Options::Builder()
.InBrowserProcess(params)
.AutoStartServiceManagerConnection(false)
@@ -636,7 +636,7 @@ RenderThreadImpl::RenderThreadImpl(
}
void RenderThreadImpl::Init(
- scoped_refptr<base::SingleThreadTaskRunner>& resource_task_queue) {
+ const scoped_refptr<base::SingleThreadTaskRunner>& resource_task_queue) {
TRACE_EVENT0("startup", "RenderThreadImpl::Init");
base::trace_event::TraceLog::GetInstance()->SetThreadSortIndex(
@@ -1231,7 +1231,7 @@ void RenderThreadImpl::InitializeCompositorThread() {
}
void RenderThreadImpl::InitializeWebKit(
- scoped_refptr<base::SingleThreadTaskRunner>& resource_task_queue) {
+ const scoped_refptr<base::SingleThreadTaskRunner>& resource_task_queue) {
DCHECK(!blink_platform_impl_);
const base::CommandLine& command_line =
« no previous file with comments | « content/renderer/render_thread_impl.h ('k') | content/renderer/render_thread_impl_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698