Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1856)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 256843006: Get current tab url from requesting contexts. (Closed)

Created:
6 years, 8 months ago by achuithb
Modified:
6 years, 8 months ago
Reviewers:
tonyg
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Get current tab url from requesting contexts. This fixes a problem where the url gets stale after navigation. BUG=365238 TEST=testTabUrl Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266467

Patch Set 1 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -3 lines) Patch
M tools/telemetry/telemetry/core/backends/chrome/inspector_backend.py View 1 chunk +4 lines, -1 line 0 comments Download
M tools/telemetry/telemetry/core/tab_unittest.py View 1 chunk +5 lines, -0 lines 0 comments Download
M tools/telemetry/telemetry/unittest/tab_test_case.py View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
achuithb
Please take a look, Tony
6 years, 8 months ago (2014-04-25 23:41:51 UTC) #1
tonyg
lgtm Thanks!
6 years, 8 months ago (2014-04-26 00:05:46 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/achuith@chromium.org/256843006/20001
6 years, 8 months ago (2014-04-26 00:08:25 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-26 06:46:09 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on win_chromium_x64_rel
6 years, 8 months ago (2014-04-26 06:46:09 UTC) #5
achuithb
The CQ bit was checked by achuith@chromium.org
6 years, 8 months ago (2014-04-26 10:43:05 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/achuith@chromium.org/256843006/20001
6 years, 8 months ago (2014-04-26 10:43:44 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-26 12:20:40 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on win_chromium_x64_rel
6 years, 8 months ago (2014-04-26 12:20:41 UTC) #9
tonyg
The CQ bit was checked by tonyg@chromium.org
6 years, 8 months ago (2014-04-26 13:18:40 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/achuith@chromium.org/256843006/20001
6 years, 8 months ago (2014-04-26 13:19:15 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-26 13:29:35 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on win_chromium_x64_rel
6 years, 8 months ago (2014-04-26 13:29:36 UTC) #13
tonyg
The CQ bit was checked by tonyg@chromium.org
6 years, 8 months ago (2014-04-26 13:31:14 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/achuith@chromium.org/256843006/20001
6 years, 8 months ago (2014-04-26 13:31:40 UTC) #15
commit-bot: I haz the power
6 years, 8 months ago (2014-04-28 07:18:17 UTC) #16
Message was sent while issue was closed. 
Change committed as 266467

Powered by Google App Engine
This is Rietveld 408576698