public/web/WebViewClient.h - Issue 256843004: Get the WebGeolocationClient from WebFrameClient instead of WebViewClient.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: public/web/WebViewClient.h

Issue 256843004: Get the WebGeolocationClient from WebFrameClient instead of WebViewClient. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: fix layouttest, fix webkit_unit_tests crash, remove obsolete layout test Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: public/web/WebViewClient.h

diff --git a/public/web/WebViewClient.h b/public/web/WebViewClient.h

index 7548bb61c4f27d4af5c882bbc453d9d7eb6b71d5..b358233c235475fc3b6133aecc13f9b4cd798212 100644

--- a/public/web/WebViewClient.h

+++ b/public/web/WebViewClient.h

@@ -56,8 +56,6 @@ class WebElement;

class WebExternalPopupMenu;

class WebExternalPopupMenuClient;

class WebFileChooserCompletion;

-class WebGeolocationClient;

-class WebGeolocationService;

class WebGestureEvent;

class WebHitTestResult;

class WebImage;

@@ -248,14 +246,6 @@ public:

virtual void didUpdateInspectorSetting(const WebString& key, const WebString& value) { }

- // Geolocation ---------------------------------------------------------

- // Access the embedder API for (client-based) geolocation client .

- virtual WebGeolocationClient* geolocationClient() { return 0; }

- // Access the embedder API for (non-client-based) geolocation services.

- virtual WebGeolocationService* geolocationService() { return 0; }

// Speech --------------------------------------------------------------

// Access the embedder API for speech input services.

« Source/modules/geolocation/Geolocation.h ('K') | « public/web/WebFrameClient.h ('k') | no next file » | no next file with comments »