Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Unified Diff: LayoutTests/fast/dom/Geolocation/script-tests/disconnected-frame-permission-denied.js

Issue 256843004: Get the WebGeolocationClient from WebFrameClient instead of WebViewClient. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: fix layouttest, fix webkit_unit_tests crash, remove obsolete layout test Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/fast/dom/Geolocation/script-tests/disconnected-frame-permission-denied.js
diff --git a/LayoutTests/fast/dom/Geolocation/script-tests/disconnected-frame-permission-denied.js b/LayoutTests/fast/dom/Geolocation/script-tests/disconnected-frame-permission-denied.js
index 6ff63c99b2ee6ae539f9aee5f76c3551c5c38e8c..6792b64155e4e3bd13de0c0ed5166603a01e55cb 100644
--- a/LayoutTests/fast/dom/Geolocation/script-tests/disconnected-frame-permission-denied.js
+++ b/LayoutTests/fast/dom/Geolocation/script-tests/disconnected-frame-permission-denied.js
@@ -3,15 +3,16 @@ description("Tests that when a request is made on a Geolocation object, permissi
if (!window.testRunner || !window.internals)
debug('This test can not run without testRunner or internals');
-internals.setGeolocationClientMock(document);
-
-// Prime the Geolocation instance by denying permission. This makes sure that we execute the
-// same code path for both preemptive and non-preemptive permissions policies.
-internals.setGeolocationPermission(document, false);
-internals.setGeolocationPosition(document, 51.478, -0.166, 100);
-
var error;
function onIframeLoaded() {
+ var iframeDocument = iframe.contentWindow.document;
+ internals.setGeolocationClientMock(iframeDocument);
+
+ // Prime the Geolocation instance by denying permission. This makes sure that we execute the
+ // same code path for both preemptive and non-preemptive permissions policies.
+ internals.setGeolocationPermission(iframeDocument, false);
+ internals.setGeolocationPosition(iframeDocument, 51.478, -0.166, 100);
+
iframeGeolocation = iframe.contentWindow.navigator.geolocation;
iframeGeolocation.getCurrentPosition(function() {
testFailed('Success callback invoked unexpectedly');

Powered by Google App Engine
This is Rietveld 408576698