Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2730)

Unified Diff: Source/web/WebViewImpl.cpp

Issue 256843004: Get the WebGeolocationClient from WebFrameClient instead of WebViewClient. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: fix linking errors Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/web/WebViewImpl.cpp
diff --git a/Source/web/WebViewImpl.cpp b/Source/web/WebViewImpl.cpp
index 94ab8cc45b04f89c0276867bc1c142168416aa00..af5e44b63a02f65b54035a8366e6f7441c24f36f 100644
--- a/Source/web/WebViewImpl.cpp
+++ b/Source/web/WebViewImpl.cpp
@@ -82,7 +82,6 @@
#include "core/rendering/compositing/RenderLayerCompositor.h"
#include "modules/device_orientation/DeviceOrientationInspectorAgent.h"
#include "modules/encryptedmedia/MediaKeysController.h"
-#include "modules/geolocation/GeolocationController.h"
#include "modules/indexeddb/InspectorIndexedDBAgent.h"
#include "modules/push_messaging/PushController.h"
#include "platform/ContextMenu.h"
@@ -130,7 +129,6 @@
#include "web/ContextFeaturesClientImpl.h"
#include "web/DatabaseClientImpl.h"
#include "web/FullscreenController.h"
-#include "web/GeolocationClientProxy.h"
#include "web/GraphicsLayerFactoryChromium.h"
#include "web/LinkHighlight.h"
#include "web/LocalFileSystemClient.h"
@@ -386,7 +384,6 @@ WebViewImpl::WebViewImpl(WebViewClient* client)
, m_layerTreeViewCommitsDeferred(false)
, m_matchesHeuristicsForGpuRasterization(false)
, m_recreatingGraphicsContext(false)
- , m_geolocationClientProxy(adoptPtr(new GeolocationClientProxy(client ? client->geolocationClient() : 0)))
, m_flingModifier(0)
, m_flingSourceDevice(false)
, m_fullscreenController(FullscreenController::create(this))
@@ -418,8 +415,6 @@ WebViewImpl::WebViewImpl(WebViewClient* client)
provideContextFeaturesTo(*m_page, ContextFeaturesClientImpl::create());
DeviceOrientationInspectorAgent::provideTo(*m_page);
- provideGeolocationTo(*m_page, m_geolocationClientProxy.get());
- m_geolocationClientProxy->setController(GeolocationController::from(m_page.get()));
provideLocalFileSystemTo(*m_page, LocalFileSystemClient::create());
provideDatabaseClientTo(*m_page, DatabaseClientImpl::create());

Powered by Google App Engine
This is Rietveld 408576698