Source/modules/geolocation/testing/GeolocationClientMock.h - Issue 256843004: Get the WebGeolocationClient from WebFrameClient instead of WebViewClient.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/geolocation/testing/GeolocationClientMock.h

Issue 256843004: Get the WebGeolocationClient from WebFrameClient instead of WebViewClient. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: fix linking errors Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/modules/geolocation/GeolocationInspectorAgent.cpp ('k') | Source/modules/geolocation/testing/GeolocationClientMock.cpp » ('j') | Source/modules/geolocation/testing/InternalsGeolocation.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/geolocation/testing/GeolocationClientMock.h

diff --git a/Source/modules/geolocation/testing/GeolocationClientMock.h b/Source/modules/geolocation/testing/GeolocationClientMock.h

index a30890d859946af377d3cb7c84a4c2b5d014fe3d..3cd22bbb3bf2c732bb57769d9e8b0f8c6e32ac67 100644

--- a/Source/modules/geolocation/testing/GeolocationClientMock.h

+++ b/Source/modules/geolocation/testing/GeolocationClientMock.h

@@ -50,8 +50,6 @@ public:

GeolocationClientMock();

virtual ~GeolocationClientMock();

- void setController(GeolocationController*);

void setPosition(PassRefPtrWillBeRawPtr<GeolocationPosition>);

void setPositionUnavailableError(const String& errorMessage);

void setPermission(bool allowed);

@@ -65,6 +63,8 @@ public:

virtual GeolocationPosition* lastPosition() OVERRIDE;

virtual void requestPermission(Geolocation*) OVERRIDE;

virtual void cancelPermissionRequest(Geolocation*) OVERRIDE;

+ void controllerForTestAdded(GeolocationController*) OVERRIDE;

+ void controllerForTestRemoved(GeolocationController*) OVERRIDE;

private:

void asyncUpdateController();

@@ -75,7 +75,7 @@ private:

void clearError();

- GeolocationController* m_controller;

+ HashSet<GeolocationController*> m_controllers;

RefPtrWillBePersistent<GeolocationPosition> m_lastPosition;

bool m_hasError;

String m_errorMessage;