Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1344)

Unified Diff: Source/modules/geolocation/GeolocationInspectorAgent.h

Issue 256843004: Get the WebGeolocationClient from WebFrameClient instead of WebViewClient. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: fix linking errors Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/geolocation/GeolocationInspectorAgent.h
diff --git a/Source/modules/geolocation/GeolocationInspectorAgent.h b/Source/modules/geolocation/GeolocationInspectorAgent.h
index 906ae6ff3edae9ce94bffcd88f5c2f1a60695b27..466e0311369143f5b3d6a681ab29cb854b04179f 100644
--- a/Source/modules/geolocation/GeolocationInspectorAgent.h
+++ b/Source/modules/geolocation/GeolocationInspectorAgent.h
@@ -34,7 +34,7 @@
#include "core/inspector/InspectorBaseAgent.h"
#include "modules/geolocation/GeolocationPosition.h"
-#include "wtf/HashMap.h"
+#include "wtf/HashSet.h"
#include "wtf/text/WTFString.h"
namespace WebCore {
@@ -46,7 +46,7 @@ typedef String ErrorString;
class GeolocationInspectorAgent FINAL : public InspectorBaseAgent<GeolocationInspectorAgent>, public InspectorBackendDispatcher::GeolocationCommandHandler {
WTF_MAKE_NONCOPYABLE(GeolocationInspectorAgent);
public:
- static PassOwnPtr<GeolocationInspectorAgent> create(GeolocationController*);
+ static PassOwnPtr<GeolocationInspectorAgent> create();
virtual ~GeolocationInspectorAgent();
// Protocol methods.
@@ -56,9 +56,12 @@ public:
// Instrumentation method.
GeolocationPosition* overrideGeolocationPosition(GeolocationPosition*);
+ void AddController(GeolocationController*);
+ void RemoveController(GeolocationController*);
+
private:
- explicit GeolocationInspectorAgent(GeolocationController*);
- GeolocationController* m_controller;
+ GeolocationInspectorAgent();
+ WTF::HashSet<GeolocationController*> m_controllers;
bool m_geolocationOverridden;
RefPtrWillBePersistent<GeolocationPosition> m_geolocationPosition;
RefPtrWillBePersistent<GeolocationPosition> m_platformGeolocationPosition;

Powered by Google App Engine
This is Rietveld 408576698