Source/modules/geolocation/GeolocationClient.h - Issue 256843004: Get the WebGeolocationClient from WebFrameClient instead of WebViewClient.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/geolocation/GeolocationClient.h

Issue 256843004: Get the WebGeolocationClient from WebFrameClient instead of WebViewClient. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: fix linking errors Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/modules/geolocation/Geolocation.cpp ('k') | Source/modules/geolocation/GeolocationController.h » ('j') | Source/modules/geolocation/testing/InternalsGeolocation.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/geolocation/GeolocationClient.h

diff --git a/Source/modules/geolocation/GeolocationClient.h b/Source/modules/geolocation/GeolocationClient.h

index 14533c622b4d34371ed4c52cfbc6bf4888aec01f..c4a90dac8ac6061cd64da3157f35a062c99d1300 100644

--- a/Source/modules/geolocation/GeolocationClient.h

+++ b/Source/modules/geolocation/GeolocationClient.h

@@ -29,8 +29,9 @@

namespace WebCore {

class Geolocation;

+class GeolocationController;

class GeolocationPosition;

-class Page;

+class LocalFrame;

class GeolocationClient {

public:

@@ -44,11 +45,14 @@ public:

virtual void requestPermission(Geolocation*) = 0;

virtual void cancelPermissionRequest(Geolocation*) = 0;

+ virtual void controllerForTestAdded(GeolocationController*) { }

+ virtual void controllerForTestRemoved(GeolocationController*) { }

protected:

virtual ~GeolocationClient() { }

};

-void provideGeolocationTo(Page&, GeolocationClient*);

+void provideGeolocationTo(LocalFrame&, GeolocationClient*);

} // namespace WebCore