Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Side by Side Diff: Source/web/WebViewImpl.cpp

Issue 256843004: Get the WebGeolocationClient from WebFrameClient instead of WebViewClient. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: fix layouttest, fix webkit_unit_tests crash, remove obsolete layout test Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011, 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2011, 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 64 matching lines...) Expand 10 before | Expand all | Expand 10 after
75 #include "core/page/PointerLockController.h" 75 #include "core/page/PointerLockController.h"
76 #include "core/page/ScopedPageLoadDeferrer.h" 76 #include "core/page/ScopedPageLoadDeferrer.h"
77 #include "core/page/TouchDisambiguation.h" 77 #include "core/page/TouchDisambiguation.h"
78 #include "core/rendering/FastTextAutosizer.h" 78 #include "core/rendering/FastTextAutosizer.h"
79 #include "core/rendering/RenderView.h" 79 #include "core/rendering/RenderView.h"
80 #include "core/rendering/RenderWidget.h" 80 #include "core/rendering/RenderWidget.h"
81 #include "core/rendering/TextAutosizer.h" 81 #include "core/rendering/TextAutosizer.h"
82 #include "core/rendering/compositing/RenderLayerCompositor.h" 82 #include "core/rendering/compositing/RenderLayerCompositor.h"
83 #include "modules/device_orientation/DeviceOrientationInspectorAgent.h" 83 #include "modules/device_orientation/DeviceOrientationInspectorAgent.h"
84 #include "modules/encryptedmedia/MediaKeysController.h" 84 #include "modules/encryptedmedia/MediaKeysController.h"
85 #include "modules/geolocation/GeolocationController.h"
86 #include "modules/indexeddb/InspectorIndexedDBAgent.h" 85 #include "modules/indexeddb/InspectorIndexedDBAgent.h"
87 #include "modules/push_messaging/PushController.h" 86 #include "modules/push_messaging/PushController.h"
88 #include "platform/ContextMenu.h" 87 #include "platform/ContextMenu.h"
89 #include "platform/ContextMenuItem.h" 88 #include "platform/ContextMenuItem.h"
90 #include "platform/Cursor.h" 89 #include "platform/Cursor.h"
91 #include "platform/KeyboardCodes.h" 90 #include "platform/KeyboardCodes.h"
92 #include "platform/NotImplemented.h" 91 #include "platform/NotImplemented.h"
93 #include "platform/OverscrollTheme.h" 92 #include "platform/OverscrollTheme.h"
94 #include "platform/PlatformGestureEvent.h" 93 #include "platform/PlatformGestureEvent.h"
95 #include "platform/PlatformKeyboardEvent.h" 94 #include "platform/PlatformKeyboardEvent.h"
(...skipping 27 matching lines...) Expand all
123 #include "public/web/WebPlugin.h" 122 #include "public/web/WebPlugin.h"
124 #include "public/web/WebPluginAction.h" 123 #include "public/web/WebPluginAction.h"
125 #include "public/web/WebRange.h" 124 #include "public/web/WebRange.h"
126 #include "public/web/WebTextInputInfo.h" 125 #include "public/web/WebTextInputInfo.h"
127 #include "public/web/WebViewClient.h" 126 #include "public/web/WebViewClient.h"
128 #include "public/web/WebWindowFeatures.h" 127 #include "public/web/WebWindowFeatures.h"
129 #include "web/CompositionUnderlineVectorBuilder.h" 128 #include "web/CompositionUnderlineVectorBuilder.h"
130 #include "web/ContextFeaturesClientImpl.h" 129 #include "web/ContextFeaturesClientImpl.h"
131 #include "web/DatabaseClientImpl.h" 130 #include "web/DatabaseClientImpl.h"
132 #include "web/FullscreenController.h" 131 #include "web/FullscreenController.h"
133 #include "web/GeolocationClientProxy.h"
134 #include "web/GraphicsLayerFactoryChromium.h" 132 #include "web/GraphicsLayerFactoryChromium.h"
135 #include "web/LinkHighlight.h" 133 #include "web/LinkHighlight.h"
136 #include "web/LocalFileSystemClient.h" 134 #include "web/LocalFileSystemClient.h"
137 #include "web/MIDIClientProxy.h" 135 #include "web/MIDIClientProxy.h"
138 #include "web/PopupContainer.h" 136 #include "web/PopupContainer.h"
139 #include "web/PrerendererClientImpl.h" 137 #include "web/PrerendererClientImpl.h"
140 #include "web/SpeechInputClientImpl.h" 138 #include "web/SpeechInputClientImpl.h"
141 #include "web/SpeechRecognitionClientProxy.h" 139 #include "web/SpeechRecognitionClientProxy.h"
142 #include "web/StorageQuotaClientImpl.h" 140 #include "web/StorageQuotaClientImpl.h"
143 #include "web/ValidationMessageClientImpl.h" 141 #include "web/ValidationMessageClientImpl.h"
(...skipping 242 matching lines...) Expand 10 before | Expand all | Expand 10 after
386 , m_isTransparent(false) 384 , m_isTransparent(false)
387 , m_tabsToLinks(false) 385 , m_tabsToLinks(false)
388 , m_layerTreeView(0) 386 , m_layerTreeView(0)
389 , m_rootLayer(0) 387 , m_rootLayer(0)
390 , m_rootGraphicsLayer(0) 388 , m_rootGraphicsLayer(0)
391 , m_rootTransformLayer(0) 389 , m_rootTransformLayer(0)
392 , m_graphicsLayerFactory(adoptPtr(new GraphicsLayerFactoryChromium(this))) 390 , m_graphicsLayerFactory(adoptPtr(new GraphicsLayerFactoryChromium(this)))
393 , m_isAcceleratedCompositingActive(false) 391 , m_isAcceleratedCompositingActive(false)
394 , m_layerTreeViewCommitsDeferred(false) 392 , m_layerTreeViewCommitsDeferred(false)
395 , m_recreatingGraphicsContext(false) 393 , m_recreatingGraphicsContext(false)
396 , m_geolocationClientProxy(adoptPtr(new GeolocationClientProxy(client ? clie nt->geolocationClient() : 0)))
397 , m_flingModifier(0) 394 , m_flingModifier(0)
398 , m_flingSourceDevice(false) 395 , m_flingSourceDevice(false)
399 , m_fullscreenController(FullscreenController::create(this)) 396 , m_fullscreenController(FullscreenController::create(this))
400 , m_showFPSCounter(false) 397 , m_showFPSCounter(false)
401 , m_showPaintRects(false) 398 , m_showPaintRects(false)
402 , m_showDebugBorders(false) 399 , m_showDebugBorders(false)
403 , m_continuousPaintingEnabled(false) 400 , m_continuousPaintingEnabled(false)
404 , m_showScrollBottleneckRects(false) 401 , m_showScrollBottleneckRects(false)
405 , m_baseBackgroundColor(Color::white) 402 , m_baseBackgroundColor(Color::white)
406 , m_backgroundColorOverride(Color::transparent) 403 , m_backgroundColorOverride(Color::transparent)
(...skipping 15 matching lines...) Expand all
422 provideMIDITo(*m_page, MIDIClientProxy::create(client ? client->webMIDIClien t() : 0)); 419 provideMIDITo(*m_page, MIDIClientProxy::create(client ? client->webMIDIClien t() : 0));
423 #if ENABLE(INPUT_SPEECH) 420 #if ENABLE(INPUT_SPEECH)
424 provideSpeechInputTo(*m_page, SpeechInputClientImpl::create(client)); 421 provideSpeechInputTo(*m_page, SpeechInputClientImpl::create(client));
425 #endif 422 #endif
426 provideSpeechRecognitionTo(*m_page, SpeechRecognitionClientProxy::create(cli ent ? client->speechRecognizer() : 0)); 423 provideSpeechRecognitionTo(*m_page, SpeechRecognitionClientProxy::create(cli ent ? client->speechRecognizer() : 0));
427 provideNavigatorContentUtilsTo(*m_page, NavigatorContentUtilsClientImpl::cre ate(this)); 424 provideNavigatorContentUtilsTo(*m_page, NavigatorContentUtilsClientImpl::cre ate(this));
428 425
429 provideContextFeaturesTo(*m_page, ContextFeaturesClientImpl::create()); 426 provideContextFeaturesTo(*m_page, ContextFeaturesClientImpl::create());
430 if (RuntimeEnabledFeatures::deviceOrientationEnabled()) 427 if (RuntimeEnabledFeatures::deviceOrientationEnabled())
431 DeviceOrientationInspectorAgent::provideTo(*m_page); 428 DeviceOrientationInspectorAgent::provideTo(*m_page);
432 provideGeolocationTo(*m_page, m_geolocationClientProxy.get());
433 m_geolocationClientProxy->setController(GeolocationController::from(m_page.g et()));
434 429
435 provideLocalFileSystemTo(*m_page, LocalFileSystemClient::create()); 430 provideLocalFileSystemTo(*m_page, LocalFileSystemClient::create());
436 provideDatabaseClientTo(*m_page, DatabaseClientImpl::create()); 431 provideDatabaseClientTo(*m_page, DatabaseClientImpl::create());
437 InspectorIndexedDBAgent::provideTo(m_page.get()); 432 InspectorIndexedDBAgent::provideTo(m_page.get());
438 provideStorageQuotaClientTo(*m_page, StorageQuotaClientImpl::create()); 433 provideStorageQuotaClientTo(*m_page, StorageQuotaClientImpl::create());
439 m_page->setValidationMessageClient(ValidationMessageClientImpl::create(*this )); 434 m_page->setValidationMessageClient(ValidationMessageClientImpl::create(*this ));
440 provideWorkerGlobalScopeProxyProviderTo(*m_page, WorkerGlobalScopeProxyProvi derImpl::create()); 435 provideWorkerGlobalScopeProxyProviderTo(*m_page, WorkerGlobalScopeProxyProvi derImpl::create());
441 436
442 m_page->makeOrdinary(); 437 m_page->makeOrdinary();
443 438
(...skipping 3622 matching lines...) Expand 10 before | Expand all | Expand 10 after
4066 const PageScaleConstraints& constraints = m_pageScaleConstraintsSet.pageDefi nedConstraints(); 4061 const PageScaleConstraints& constraints = m_pageScaleConstraintsSet.pageDefi nedConstraints();
4067 4062
4068 if (!mainFrameImpl() || !mainFrameImpl()->frameView()) 4063 if (!mainFrameImpl() || !mainFrameImpl()->frameView())
4069 return false; 4064 return false;
4070 4065
4071 return mainFrameImpl()->frameView()->layoutSize().width() == m_size.width 4066 return mainFrameImpl()->frameView()->layoutSize().width() == m_size.width
4072 || (constraints.minimumScale == constraints.maximumScale && constraints. minimumScale != -1); 4067 || (constraints.minimumScale == constraints.maximumScale && constraints. minimumScale != -1);
4073 } 4068 }
4074 4069
4075 } // namespace blink 4070 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698