Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Side by Side Diff: Source/modules/geolocation/GeolocationController.h

Issue 256843004: Get the WebGeolocationClient from WebFrameClient instead of WebViewClient. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: fix layouttest, fix webkit_unit_tests crash, remove obsolete layout test Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Apple Inc. All rights reserved. 2 * Copyright (C) 2009 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
11 * documentation and/or other materials provided with the distribution. 11 * documentation and/or other materials provided with the distribution.
12 * 12 *
13 * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS'' 13 * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS''
14 * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, 14 * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
15 * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR 15 * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
16 * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS 16 * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS
17 * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR 17 * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
18 * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF 18 * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
19 * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS 19 * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
20 * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN 20 * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
21 * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) 21 * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
22 * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF 22 * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
23 * THE POSSIBILITY OF SUCH DAMAGE. 23 * THE POSSIBILITY OF SUCH DAMAGE.
24 */ 24 */
25 25
26 #ifndef GeolocationController_h 26 #ifndef GeolocationController_h
27 #define GeolocationController_h 27 #define GeolocationController_h
28 28
29 #include "core/page/Page.h" 29 #include "core/frame/LocalFrame.h"
30 #include "core/page/PageLifecycleObserver.h" 30 #include "core/page/PageLifecycleObserver.h"
31 #include "modules/geolocation/Geolocation.h" 31 #include "modules/geolocation/Geolocation.h"
32 #include "platform/heap/Handle.h" 32 #include "platform/heap/Handle.h"
33 #include "wtf/HashSet.h" 33 #include "wtf/HashSet.h"
34 #include "wtf/Noncopyable.h" 34 #include "wtf/Noncopyable.h"
35 #include "wtf/RefPtr.h" 35 #include "wtf/RefPtr.h"
36 36
37 namespace WebCore { 37 namespace WebCore {
38 38
39 class GeolocationInspectorAgent; 39 class GeolocationInspectorAgent;
40 class GeolocationClient; 40 class GeolocationClient;
41 class GeolocationError; 41 class GeolocationError;
42 class GeolocationPosition; 42 class GeolocationPosition;
43 class Page;
44 43
45 class GeolocationController FINAL : public Supplement<Page>, public PageLifecycl eObserver { 44 class GeolocationController FINAL : public Supplement<LocalFrame>, public PageLi fecycleObserver {
46 WTF_MAKE_NONCOPYABLE(GeolocationController); 45 WTF_MAKE_NONCOPYABLE(GeolocationController);
47 public: 46 public:
48 virtual ~GeolocationController(); 47 virtual ~GeolocationController();
49 48
50 static PassOwnPtr<GeolocationController> create(Page&, GeolocationClient*); 49 static PassOwnPtr<GeolocationController> create(LocalFrame&, GeolocationClie nt*);
51 50
52 void addObserver(Geolocation*, bool enableHighAccuracy); 51 void addObserver(Geolocation*, bool enableHighAccuracy);
53 void removeObserver(Geolocation*); 52 void removeObserver(Geolocation*);
54 53
55 void requestPermission(Geolocation*); 54 void requestPermission(Geolocation*);
56 void cancelPermissionRequest(Geolocation*); 55 void cancelPermissionRequest(Geolocation*);
57 56
58 void positionChanged(GeolocationPosition*); 57 void positionChanged(GeolocationPosition*);
59 void errorOccurred(GeolocationError*); 58 void errorOccurred(GeolocationError*);
60 59
61 GeolocationPosition* lastPosition(); 60 GeolocationPosition* lastPosition();
62 61
63 void setClientForTest(GeolocationClient*); 62 void setClientForTest(GeolocationClient*);
64 bool hasClientForTest() { return m_hasClientForTest; } 63 bool hasClientForTest() { return m_hasClientForTest; }
65 GeolocationClient* client() { return m_client; } 64 GeolocationClient* client() { return m_client; }
66 65
67 // Inherited from PageLifecycleObserver. 66 // Inherited from PageLifecycleObserver.
68 virtual void pageVisibilityChanged() OVERRIDE; 67 virtual void pageVisibilityChanged() OVERRIDE;
69 68
70 static const char* supplementName(); 69 static const char* supplementName();
71 static GeolocationController* from(Page* page) { return static_cast<Geolocat ionController*>(Supplement<Page>::from(page, supplementName())); } 70 static GeolocationController* from(LocalFrame* frame) { return static_cast<G eolocationController*>(Supplement<LocalFrame>::from(frame, supplementName())); }
72 71
73 virtual void trace(Visitor*) OVERRIDE { }; 72 virtual void trace(Visitor*) OVERRIDE { };
74 73
75 virtual void willBeDestroyed() OVERRIDE; 74 virtual void willBeDestroyed() OVERRIDE;
76 75
77 private: 76 private:
78 GeolocationController(Page&, GeolocationClient*); 77 GeolocationController(LocalFrame&, GeolocationClient*);
79 78
80 void startUpdatingIfNeeded(); 79 void startUpdatingIfNeeded();
81 void stopUpdatingIfNeeded(); 80 void stopUpdatingIfNeeded();
82 81
83 GeolocationClient* m_client; 82 GeolocationClient* m_client;
84 bool m_hasClientForTest; 83 bool m_hasClientForTest;
85 84
86 RefPtrWillBePersistent<GeolocationPosition> m_lastPosition; 85 RefPtrWillBePersistent<GeolocationPosition> m_lastPosition;
87 typedef WillBePersistentHeapHashSet<RefPtrWillBeMember<Geolocation> > Observ ersSet; 86 typedef WillBePersistentHeapHashSet<RefPtrWillBeMember<Geolocation> > Observ ersSet;
88 // All observers; both those requesting high accuracy and those not. 87 // All observers; both those requesting high accuracy and those not.
89 ObserversSet m_observers; 88 ObserversSet m_observers;
90 ObserversSet m_highAccuracyObservers; 89 ObserversSet m_highAccuracyObservers;
91 bool m_isClientUpdating; 90 bool m_isClientUpdating;
92 GeolocationInspectorAgent* m_inspectorAgent; 91 GeolocationInspectorAgent* m_inspectorAgent;
93 }; 92 };
94 93
95 } // namespace WebCore 94 } // namespace WebCore
96 95
97 #endif // GeolocationController_h 96 #endif // GeolocationController_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698