bluetooth: Add notification system to internals page.

chrome/browser/resources/bluetooth_internals/device_table.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * Javascript for DeviceTable UI, served from chrome://bluetooth-internals/.
  */
 
 cr.define('device_table', function() {
   var COLUMNS = {
     NAME: 0,
     ADDRESS: 1,
     RSSI: 2,
     SERVICES: 3,
     CONNECTION_STATE: 4,
     INSPECT_LINK: 5,
-    CONNECTION_ERROR: 6,
   };
 
   /**
    * A table that lists the devices and responds to changes in the given
    * DeviceCollection. Fires events for inspection requests from listed
    * devices.
    * @constructor
    * @extends {HTMLTableElement}
    */
   var DeviceTable = cr.ui.define(function() {
@@ skipping 82 matching lines @@
       var row = this.body_.insertRow(index);
       row.id = device.address;
 
       for (var i = 0; i < this.headers_.length; i++) {
         row.insertCell();
       }
 
       // Make two extra cells for the inspect link and connect errors.
       var inspectCell = row.insertCell();
 
-      // TODO(crbug.com/663830): Replace connection error column with better
-      // notification system.
-      var connectErrorCell = row.insertCell();
-
       var inspectLink = document.createElement('a', 'action-link');
       inspectCell.appendChild(inspectLink);
       inspectLink.addEventListener('click', function() {
         this.handleInspectClick_(row.sectionRowIndex);
       }.bind(this));
 
       this.updateRow_(device, row.sectionRowIndex);
     },
 
     /**
@@ skipping 31 matching lines @@
           break;
         case device_collection.ConnectionStatus.CONNECTED:
           inspectLink.textContent = 'Forget';
           break;
         case device_collection.ConnectionStatus.CONNECTING:
           inspectLink.disabled = true;
           break;
         default: assert('case not handled');
       }
 
-      // TODO(crbug.com/663830): Replace connection error column with better
-      // notification system.
-      var connectErrorCell = row.cells[COLUMNS.CONNECTION_ERROR];
-      connectErrorCell.textContent = device.connectionMessage;
-      connectErrorCell.hidden = !device.connectionMessage;
-
       // Update the properties based on the header field path.
       for (var i = 0; i < this.headers_.length; i++) {
         var header = this.headers_[i];
         var propName = header.dataset.field;
 
         var parts = propName.split('.');
         var obj = device;
         while (obj != null && parts.length > 0) {
           var part = parts.shift();
           obj = obj[part];
         }
 
         if (propName == 'is_gatt_connected') {
           obj = obj ? 'Connected' : 'Not Connected';
         }
 
         var cell = row.cells[i];
         cell.textContent = obj == null ? 'Unknown' : obj;
         cell.dataset.label = header.textContent;
       }
     },
   };
 
   return {
     DeviceTable: DeviceTable,
   };
 });