chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadHistoryAdapter.java - Issue 2568263002: [Downloads UI] Add histograms for file extensions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadHistoryAdapter.java

Issue 2568263002: [Downloads UI] Add histograms for file extensions (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadFilter.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadHistoryItemWrapper.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadHistoryAdapter.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadHistoryAdapter.java b/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadHistoryAdapter.java

index 53bf51c9fad132f57e01edee344a99d725f35aa7..cb93fa8266fb76e36ae5409c88530ab086d6e708 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadHistoryAdapter.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadHistoryAdapter.java

@@ -104,7 +104,15 @@ public class DownloadHistoryAdapter extends DateDividedAdapter implements Downlo

DownloadItemWrapper wrapper = createDownloadItemWrapper(item);

if (!wrapper.isComplete()) continue;

- if (addDownloadHistoryItemWrapper(wrapper)) itemCounts[wrapper.getFilterType()]++;

+ if (addDownloadHistoryItemWrapper(wrapper)) {

+ itemCounts[wrapper.getFilterType()]++;

+ if (!isOffTheRecord && wrapper.getFilterType() == DownloadFilter.FILTER_OTHER) {

+ RecordHistogram.recordEnumeratedHistogram(

+ "Android.DownloadManager.OtherExtensions.InitialCount",

+ wrapper.getFileExtensionType(),

+ DownloadHistoryItemWrapper.FILE_EXTENSION_BOUNDARY);

+ }

}

if (!isOffTheRecord) recordDownloadCountHistograms(itemCounts);