components/ntp_tiles/most_visited_sites.cc - Issue 2568133005: [SuggestionsService] Split SuggestionsService interface from impl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/ntp_tiles/most_visited_sites.cc

Issue 2568133005: [SuggestionsService] Split SuggestionsService interface from impl (Closed)

Patch Set: Moved impl to dedicated file. Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/ntp_tiles/most_visited_sites.cc

diff --git a/components/ntp_tiles/most_visited_sites.cc b/components/ntp_tiles/most_visited_sites.cc

index 397b9e417e57e19ef82cba73c832ca1ae7f70b0d..84b7b3859e1222ff570fcf98693199a123e8f922 100644

--- a/components/ntp_tiles/most_visited_sites.cc

+++ b/components/ntp_tiles/most_visited_sites.cc

@@ -161,7 +161,8 @@ void MostVisitedSites::BuildCurrentTiles() {

// Get the current suggestions from cache. If the cache is empty, this will

// fall back to TopSites.

OnSuggestionsProfileAvailable(

- suggestions_service_->GetSuggestionsDataFromCache());

+ suggestions_service_->GetSuggestionsDataFromCache().value_or(

+ SuggestionsProfile()));

}

void MostVisitedSites::InitiateTopSitesQuery() {