chrome/browser/search/suggestions/suggestions_ui.cc - Issue 2568133005: [SuggestionsService] Split SuggestionsService interface from impl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/search/suggestions/suggestions_ui.cc

Issue 2568133005: [SuggestionsService] Split SuggestionsService interface from impl (Closed)

Patch Set: Moved impl to dedicated file. Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/search/suggestions/suggestions_ui.cc

diff --git a/chrome/browser/search/suggestions/suggestions_ui.cc b/chrome/browser/search/suggestions/suggestions_ui.cc

index 85566ba895595d8e9e588ee6805fa37859f6e6cd..8fef7fbac493adcecf96347ef7b38f2262220670 100644

--- a/chrome/browser/search/suggestions/suggestions_ui.cc

+++ b/chrome/browser/search/suggestions/suggestions_ui.cc

@@ -200,7 +200,8 @@ void SuggestionsSource::StartDataRequest(

suggestions_service->FetchSuggestionsData();

SuggestionsProfile suggestions_profile =

- suggestions_service->GetSuggestionsDataFromCache();

+ suggestions_service->GetSuggestionsDataFromCache().value_or(

+ SuggestionsProfile());

size_t size = suggestions_profile.suggestions_size();

if (!size) {

std::string output = RenderOutputHtmlNoSuggestions(is_refresh);