Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 256813002: Use [UIScreen mainScreen] instead of [[UIScreen screens] objectAtIndex:0]. (Closed)

Created:
6 years, 8 months ago by jif
Modified:
6 years, 7 months ago
Reviewers:
jif-google, oshima
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Use [UIScreen mainScreen] instead of [[UIScreen screens] objectAtIndex:0]. BUG=338626 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266686

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M ui/gfx/screen_ios.mm View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
jif-google
ptal
6 years, 8 months ago (2014-04-25 16:52:22 UTC) #1
oshima
On 2014/04/25 16:52:22, jif-google wrote: > ptal I'm not familiar with ios. Can you find ...
6 years, 8 months ago (2014-04-25 17:49:34 UTC) #2
jif-google
On 2014/04/25 17:49:34, oshima wrote: > On 2014/04/25 16:52:22, jif-google wrote: > > ptal > ...
6 years, 8 months ago (2014-04-28 08:31:50 UTC) #3
oshima
On 2014/04/28 08:31:50, jif-google wrote: > On 2014/04/25 17:49:34, oshima wrote: > > On 2014/04/25 ...
6 years, 7 months ago (2014-04-28 16:52:19 UTC) #4
jif
The CQ bit was checked by jif@chromium.org
6 years, 7 months ago (2014-04-28 18:12:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jif@chromium.org/256813002/1
6 years, 7 months ago (2014-04-28 18:13:16 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-28 19:33:33 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_rel
6 years, 7 months ago (2014-04-28 19:33:33 UTC) #8
jif
The CQ bit was checked by jif@chromium.org
6 years, 7 months ago (2014-04-28 20:03:35 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jif@chromium.org/256813002/1
6 years, 7 months ago (2014-04-28 20:04:14 UTC) #10
commit-bot: I haz the power
6 years, 7 months ago (2014-04-28 23:24:30 UTC) #11
Message was sent while issue was closed.
Change committed as 266686

Powered by Google App Engine
This is Rietveld 408576698