Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2568123002: [DO NOT SUBMIT] Support allowpaymentrequest with out-of-process iframes (Closed)

Created:
4 years ago by please use gerrit instead
Modified:
4 years ago
Reviewers:
CC:
chromium-reviews, rouslan+payments_chromium.org, mlamouri+watch-blink_chromium.org, blink-reviews-html_chromium.org, jam, dcheng, gogerald+paymentswatch_chromium.org, haraken, dglazkov+blink, darin-cc_chromium.org, blink-reviews, blink-reviews-api_chromium.org, kinuko+watch, sebsg+paymentswatch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DO NOT SUBMIT] Support allowpaymentrequest with out-of-process iframes BUG=669585 patch from issue 2545693002 at patchset 120001 (http://crrev.com/2545693002#ps120001)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+114 lines, -11 lines) Patch
M chrome/browser/payments/payment_request_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/payments/payment_request_impl.cc View 1 chunk +3 lines, -0 lines 0 comments Download
A chrome/browser/payments/site_per_process_payments_browsertest.cc View 1 chunk +66 lines, -0 lines 0 comments Download
M chrome/test/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/payment_request_iframe.html View 1 chunk +6 lines, -0 lines 0 comments Download
A chrome/test/data/payment_request_main.html View 1 chunk +2 lines, -0 lines 0 comments Download
M content/common/frame_messages.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/common/frame_owner_properties.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/common/frame_owner_properties.cc View 4 chunks +5 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/FrameOwner.h View 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLIFrameElement.h View 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLIFrameElement.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/payments/PaymentRequest.cpp View 1 chunk +2 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/RemoteFrameOwner.h View 3 chunks +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/RemoteFrameOwner.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/web/WebFrame.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/web/WebLocalFrameImpl.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/public/web/WebFrameOwnerProperties.h View 3 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 5 (5 generated)
please use gerrit instead
The CQ bit was checked by rouslan@chromium.org to run a CQ dry run
4 years ago (2016-12-12 15:23:52 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2568123002/1
4 years ago (2016-12-12 15:24:05 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years ago (2016-12-12 15:32:26 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/323705)
4 years ago (2016-12-12 15:32:27 UTC) #4
please use gerrit instead
4 years ago (2016-12-16 20:53:41 UTC) #5 
Description was changed from

==========
[DO NOT SUBMIT] Support allowpaymentrequest with out-of-process iframes

BUG=669585

patch from issue 2545693002 at patchset 120001
(http://crrev.com/2545693002#ps120001)
==========

to

==========
[DO NOT SUBMIT] Support allowpaymentrequest with out-of-process iframes

BUG=669585

patch from issue 2545693002 at patchset 120001
(http://crrev.com/2545693002#ps120001)
==========

Powered by Google App Engine
This is Rietveld 408576698