Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2135)

Unified Diff: content/renderer/render_widget.cc

Issue 2568093003: Support parsing BackgroundSpans and UnderlineSpans in Android IME's commitText() (Closed)
Patch Set: Fix commitText() logic (I think) Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_widget.cc
diff --git a/content/renderer/render_widget.cc b/content/renderer/render_widget.cc
index f25fa82c1ad78cffa9a3fd4caeadb67117cd1a80..31f0ee4b9f92c0dcc8f8289cd5896824dbddf96b 100644
--- a/content/renderer/render_widget.cc
+++ b/content/renderer/render_widget.cc
@@ -1531,9 +1531,11 @@ void RenderWidget::OnImeSetComposition(
UpdateCompositionInfo(false /* not an immediate request */);
}
-void RenderWidget::OnImeCommitText(const base::string16& text,
- const gfx::Range& replacement_range,
- int relative_cursor_pos) {
+void RenderWidget::OnImeCommitText(
+ const base::string16& text,
+ const std::vector<WebCompositionUnderline>& underlines,
+ const gfx::Range& replacement_range,
+ int relative_cursor_pos) {
#if BUILDFLAG(ENABLE_PLUGINS)
if (focused_pepper_plugin_) {
focused_pepper_plugin_->render_frame()->OnImeCommitText(
@@ -1551,7 +1553,8 @@ void RenderWidget::OnImeCommitText(const base::string16& text,
ImeEventGuard guard(this);
input_handler_->set_handling_input_event(true);
if (auto* controller = GetInputMethodController())
- controller->commitText(text, relative_cursor_pos);
+ controller->commitText(text, WebVector<WebCompositionUnderline>(underlines),
+ relative_cursor_pos);
input_handler_->set_handling_input_event(false);
UpdateCompositionInfo(false /* not an immediate request */);
}

Powered by Google App Engine
This is Rietveld 408576698