content/browser/renderer_host/render_widget_host_view_aura.cc - Issue 2568093003: Support parsing BackgroundSpans and UnderlineSpans in Android IME's commitText()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_widget_host_view_aura.cc

Issue 2568093003: Support parsing BackgroundSpans and UnderlineSpans in Android IME's commitText() (Closed)

Patch Set: Fix commitText() logic (I think) Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/renderer_host/render_widget_host_view_aura.cc

diff --git a/content/browser/renderer_host/render_widget_host_view_aura.cc b/content/browser/renderer_host/render_widget_host_view_aura.cc

index f928a0e9e749e76e9ceddd54174667c3475d7020..43e2936bc65da62e2a07e256efb498cdf3b04c21 100644

--- a/content/browser/renderer_host/render_widget_host_view_aura.cc

+++ b/content/browser/renderer_host/render_widget_host_view_aura.cc

@@ -1198,7 +1198,8 @@ void RenderWidgetHostViewAura::InsertText(const base::string16& text) {

if (text_input_manager_ && text_input_manager_->GetActiveWidget()) {

if (text.length())

text_input_manager_->GetActiveWidget()->ImeCommitText(

- text, gfx::Range::InvalidRange(), 0);

+ text, std::vector<blink::WebCompositionUnderline>(),

+ gfx::Range::InvalidRange(), 0);

else if (has_composition_text_)

text_input_manager_->GetActiveWidget()->ImeFinishComposingText(false);

}