Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Unified Diff: third_party/WebKit/Source/core/editing/InputMethodController.h

Issue 2568093003: Support parsing BackgroundSpans and UnderlineSpans in Android IME's commitText() (Closed)
Patch Set: Don't try to add default underline for commitText(), attempt to fix Mac builds Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/InputMethodController.h
diff --git a/third_party/WebKit/Source/core/editing/InputMethodController.h b/third_party/WebKit/Source/core/editing/InputMethodController.h
index 720196527424e42a12bec374795b9fa621c9f5e9..64f63cdee0e8bf86db2f67884d08e20bedb923a9 100644
--- a/third_party/WebKit/Source/core/editing/InputMethodController.h
+++ b/third_party/WebKit/Source/core/editing/InputMethodController.h
@@ -62,18 +62,20 @@ class CORE_EXPORT InputMethodController final
// international text input composition
bool hasComposition() const;
- void setComposition(const String&,
- const Vector<CompositionUnderline>&,
+ void setComposition(const String& text,
+ const Vector<CompositionUnderline>& underlines,
int selectionStart,
int selectionEnd);
- void setCompositionFromExistingText(const Vector<CompositionUnderline>&,
+ void setCompositionFromExistingText(const Vector<CompositionUnderline>& text,
unsigned compositionStart,
unsigned compositionEnd);
// Deletes ongoing composing text if any, inserts specified text, and
// changes the selection according to relativeCaretPosition, which is
// relative to the end of the inserting text.
- bool commitText(const String& text, int relativeCaretPosition);
+ bool commitText(const String& text,
+ const Vector<CompositionUnderline>& underlines,
+ int relativeCaretPosition);
// Inserts ongoing composing text; changes the selection to the end of
// the inserting text if DoNotKeepSelection, or holds the selection if

Powered by Google App Engine
This is Rietveld 408576698