content/renderer/render_widget.h - Issue 2568093003: Support parsing BackgroundSpans and UnderlineSpans in Android IME's commitText()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_widget.h

Issue 2568093003: Support parsing BackgroundSpans and UnderlineSpans in Android IME's commitText() (Closed)

Patch Set: Don't try to add default underline for commitText(), attempt to fix Mac builds Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/render_widget.h

diff --git a/content/renderer/render_widget.h b/content/renderer/render_widget.h

index 76bcebaed022f37c9f0d1281470aeb683818e08c..68b9ab15f52e9c629b6421a1e33d005d0c317274 100644

--- a/content/renderer/render_widget.h

+++ b/content/renderer/render_widget.h

@@ -491,9 +491,11 @@ class CONTENT_EXPORT RenderWidget

const gfx::Range& replacement_range,

int selection_start,

int selection_end);

- virtual void OnImeCommitText(const base::string16& text,

- const gfx::Range& replacement_range,

- int relative_cursor_pos);

+ virtual void OnImeCommitText(

+ const base::string16& text,

+ const std::vector<blink::WebCompositionUnderline>& underlines,

+ const gfx::Range& replacement_range,

+ int relative_cursor_pos);

virtual void OnImeFinishComposingText(bool keep_selection);

// Called when the device scale factor is changed, or the layer tree is