content/renderer/render_frame_impl.cc - Issue 2568093003: Support parsing BackgroundSpans and UnderlineSpans in Android IME's commitText()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_frame_impl.cc

Issue 2568093003: Support parsing BackgroundSpans and UnderlineSpans in Android IME's commitText() (Closed)

Patch Set: Don't try to add default underline for commitText(), attempt to fix Mac builds Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/render_frame_impl.cc

diff --git a/content/renderer/render_frame_impl.cc b/content/renderer/render_frame_impl.cc

index df68a6642a690b03a20aecc575f52c1cf0cb52b3..77f37a75e6819ddd37d42c69a1934df1e3728192 100644

--- a/content/renderer/render_frame_impl.cc

+++ b/content/renderer/render_frame_impl.cc

@@ -1399,8 +1399,9 @@ void RenderFrameImpl::SimulateImeSetComposition(

void RenderFrameImpl::SimulateImeCommitText(

const base::string16& text,

+ const std::vector<blink::WebCompositionUnderline>& underlines,

const gfx::Range& replacement_range) {

- render_view_->OnImeCommitText(text, replacement_range, 0);

+ render_view_->OnImeCommitText(text, underlines, replacement_range, 0);

}

void RenderFrameImpl::SimulateImeFinishComposingText(bool keep_selection) {