content/renderer/pepper/pepper_plugin_instance_impl.cc - Issue 2568093003: Support parsing BackgroundSpans and UnderlineSpans in Android IME's commitText()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/pepper/pepper_plugin_instance_impl.cc

Issue 2568093003: Support parsing BackgroundSpans and UnderlineSpans in Android IME's commitText() (Closed)

Patch Set: Don't try to add default underline for commitText(), attempt to fix Mac builds Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/pepper/pepper_plugin_instance_impl.cc

diff --git a/content/renderer/pepper/pepper_plugin_instance_impl.cc b/content/renderer/pepper/pepper_plugin_instance_impl.cc

index c039d254d2bef13c6a7e6c3998a6a8293b7c5b52..3a24c86fc2c6285b46238af2f555506c5886b262 100644

--- a/content/renderer/pepper/pepper_plugin_instance_impl.cc

+++ b/content/renderer/pepper/pepper_plugin_instance_impl.cc

@@ -2252,7 +2252,8 @@ bool PepperPluginInstanceImpl::SimulateIMEEvent(

if (!render_frame_)

return false;

render_frame_->SimulateImeCommitText(

- base::UTF8ToUTF16(input_event.character_text), gfx::Range());

+ base::UTF8ToUTF16(input_event.character_text),

+ std::vector<blink::WebCompositionUnderline>(), gfx::Range());

break;

default:

return false;