third_party/WebKit/public/web/WebInputMethodController.h - Issue 2568093003: Support parsing BackgroundSpans and UnderlineSpans in Android IME's commitText()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/public/web/WebInputMethodController.h

Issue 2568093003: Support parsing BackgroundSpans and UnderlineSpans in Android IME's commitText() (Closed)

Patch Set: Use addCompositionUnderlines() where I said I couldn't Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/public/web/WebInputMethodController.h

diff --git a/third_party/WebKit/public/web/WebInputMethodController.h b/third_party/WebKit/public/web/WebInputMethodController.h

index 001b28cae538a052efb39eb1b179330878a6259a..090d2be7657ef0e9f76d28459120c3de1f99c67f 100644

--- a/third_party/WebKit/public/web/WebInputMethodController.h

+++ b/third_party/WebKit/public/web/WebInputMethodController.h

@@ -38,7 +38,9 @@ class WebInputMethodController {

// Called to inform the controller that deleting the ongoing composition if

// any, inserting the specified text, and moving the caret according to

// relativeCaretPosition.

- virtual bool commitText(const WebString& text, int relativeCaretPosition) = 0;

+ virtual bool commitText(const WebString& text,

+ const WebVector<WebCompositionUnderline>& underlines,

+ int relativeCaretPosition) = 0;

// Called to inform the controller to confirm an ongoing composition.

virtual bool finishComposingText(