Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2969)

Unified Diff: content/renderer/render_view_browsertest.cc

Issue 2568093003: Support parsing BackgroundSpans and UnderlineSpans in Android IME's commitText() (Closed)
Patch Set: Use addCompositionUnderlines() where I said I couldn't Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/render_frame_impl.cc ('k') | content/renderer/render_widget.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_view_browsertest.cc
diff --git a/content/renderer/render_view_browsertest.cc b/content/renderer/render_view_browsertest.cc
index dba3cbfb105112f85398587a42d843ec068f92b5..5b6afa6c0b4aba941abb814991befd69d90c867b 100644
--- a/content/renderer/render_view_browsertest.cc
+++ b/content/renderer/render_view_browsertest.cc
@@ -1257,6 +1257,7 @@ TEST_F(RenderViewImplTest, ImeComposition) {
case IME_COMMITTEXT:
view()->OnImeCommitText(base::WideToUTF16(ime_message->ime_string),
+ std::vector<blink::WebCompositionUnderline>(),
gfx::Range::InvalidRange(), 0);
break;
@@ -1518,7 +1519,9 @@ TEST_F(RenderViewImplTest, GetCompositionCharacterBoundsTest) {
for (size_t i = 0; i < bounds.size(); ++i)
EXPECT_LT(0, bounds[i].width());
- view()->OnImeCommitText(empty_string, gfx::Range::InvalidRange(), 0);
+ view()->OnImeCommitText(empty_string,
+ std::vector<blink::WebCompositionUnderline>(),
+ gfx::Range::InvalidRange(), 0);
// Non surrogate pair unicode character.
const base::string16 unicode_composition = base::UTF8ToUTF16(
@@ -1529,7 +1532,8 @@ TEST_F(RenderViewImplTest, GetCompositionCharacterBoundsTest) {
ASSERT_EQ(unicode_composition.size(), bounds.size());
for (size_t i = 0; i < bounds.size(); ++i)
EXPECT_LT(0, bounds[i].width());
- view()->OnImeCommitText(empty_string, gfx::Range::InvalidRange(), 0);
+ view()->OnImeCommitText(empty_string, empty_underline,
+ gfx::Range::InvalidRange(), 0);
// Surrogate pair character.
const base::string16 surrogate_pair_char =
@@ -1543,7 +1547,8 @@ TEST_F(RenderViewImplTest, GetCompositionCharacterBoundsTest) {
ASSERT_EQ(surrogate_pair_char.size(), bounds.size());
EXPECT_LT(0, bounds[0].width());
EXPECT_EQ(0, bounds[1].width());
- view()->OnImeCommitText(empty_string, gfx::Range::InvalidRange(), 0);
+ view()->OnImeCommitText(empty_string, empty_underline,
+ gfx::Range::InvalidRange(), 0);
// Mixed string.
const base::string16 surrogate_pair_mixed_composition =
@@ -1566,7 +1571,8 @@ TEST_F(RenderViewImplTest, GetCompositionCharacterBoundsTest) {
EXPECT_LT(0, bounds[i].width());
}
}
- view()->OnImeCommitText(empty_string, gfx::Range::InvalidRange(), 0);
+ view()->OnImeCommitText(empty_string, empty_underline,
+ gfx::Range::InvalidRange(), 0);
}
#endif
« no previous file with comments | « content/renderer/render_frame_impl.cc ('k') | content/renderer/render_widget.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698