content/renderer/render_frame_impl.h - Issue 2568093003: Support parsing BackgroundSpans and UnderlineSpans in Android IME's commitText()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_frame_impl.h

Issue 2568093003: Support parsing BackgroundSpans and UnderlineSpans in Android IME's commitText() (Closed)

Patch Set: Use addCompositionUnderlines() where I said I couldn't Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/render_frame_impl.h

diff --git a/content/renderer/render_frame_impl.h b/content/renderer/render_frame_impl.h

index 2132cb23060fef2c33c36566932275c1b7763222..f6c27ad5be9a6ff99f5675af0cf27eca931c60c9 100644

--- a/content/renderer/render_frame_impl.h

+++ b/content/renderer/render_frame_impl.h

@@ -364,8 +364,10 @@ class CONTENT_EXPORT RenderFrameImpl

const std::vector<blink::WebCompositionUnderline>& underlines,

int selection_start,

int selection_end);

- void SimulateImeCommitText(const base::string16& text,

- const gfx::Range& replacement_range);

+ void SimulateImeCommitText(

+ const base::string16& text,

+ const std::vector<blink::WebCompositionUnderline>& underlines,

+ const gfx::Range& replacement_range);

void SimulateImeFinishComposingText(bool keep_selection);

// TODO(jam): remove these once the IPC handler moves from RenderView to