content/renderer/browser_plugin/browser_plugin.h - Issue 2568093003: Support parsing BackgroundSpans and UnderlineSpans in Android IME's commitText()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/browser_plugin/browser_plugin.h

Issue 2568093003: Support parsing BackgroundSpans and UnderlineSpans in Android IME's commitText() (Closed)

Patch Set: Use addCompositionUnderlines() where I said I couldn't Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/browser_plugin/browser_plugin.h

diff --git a/content/renderer/browser_plugin/browser_plugin.h b/content/renderer/browser_plugin/browser_plugin.h

index 68286d849f4b08730eefc4b378a3208265f8abed..3163dffd69394677ea953a54864d722cc64edaa9 100644

--- a/content/renderer/browser_plugin/browser_plugin.h

+++ b/content/renderer/browser_plugin/browser_plugin.h

@@ -115,8 +115,10 @@ class CONTENT_EXPORT BrowserPlugin :

const blink::WebVector<blink::WebCompositionUnderline>& underlines,

int selectionStart,

int selectionEnd) override;

- bool commitText(const blink::WebString& text,

- int relative_cursor_pos) override;

+ bool commitText(

+ const blink::WebString& text,

+ const blink::WebVector<blink::WebCompositionUnderline>& underlines,

+ int relative_cursor_pos) override;

bool finishComposingText(

blink::WebInputMethodController::ConfirmCompositionBehavior

selection_behavior) override;