content/browser/renderer_host/render_widget_host_impl.h - Issue 2568093003: Support parsing BackgroundSpans and UnderlineSpans in Android IME's commitText()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_widget_host_impl.h

Issue 2568093003: Support parsing BackgroundSpans and UnderlineSpans in Android IME's commitText() (Closed)

Patch Set: Use addCompositionUnderlines() where I said I couldn't Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/renderer_host/render_widget_host_impl.h

diff --git a/content/browser/renderer_host/render_widget_host_impl.h b/content/browser/renderer_host/render_widget_host_impl.h

index 8c17eef9be6970a9fd9b47198fb2d10594983947..1011c3510eed01517a4c9c52119e17c430649f5a 100644

--- a/content/browser/renderer_host/render_widget_host_impl.h

+++ b/content/browser/renderer_host/render_widget_host_impl.h

@@ -403,9 +403,11 @@ class CONTENT_EXPORT RenderWidgetHostImpl : public RenderWidgetHost,

// (on Windows);

// * when it receives a "commit" signal of GtkIMContext (on Linux);

// * when insertText of NSTextInput is called (on Mac).

- void ImeCommitText(const base::string16& text,

- const gfx::Range& replacement_range,

- int relative_cursor_pos);

+ void ImeCommitText(

+ const base::string16& text,

+ const std::vector<blink::WebCompositionUnderline>& underlines,

+ const gfx::Range& replacement_range,

+ int relative_cursor_pos);

// Finishes an ongoing composition.

// A browser should call this function or ImeCommitText: