Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1133)

Unified Diff: content/browser/browser_plugin/browser_plugin_guest.cc

Issue 2568093003: Support parsing BackgroundSpans and UnderlineSpans in Android IME's commitText() (Closed)
Patch Set: Use addCompositionUnderlines() where I said I couldn't Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/browser_plugin/browser_plugin_guest.cc
diff --git a/content/browser/browser_plugin/browser_plugin_guest.cc b/content/browser/browser_plugin/browser_plugin_guest.cc
index 03de0e27ea0b8c5d25d8f9cf2fc0fc90ad919e14..6bb94db6c339e0c23714e1f96e4eef3c5d6b1c73 100644
--- a/content/browser/browser_plugin/browser_plugin_guest.cc
+++ b/content/browser/browser_plugin/browser_plugin_guest.cc
@@ -897,11 +897,13 @@ void BrowserPluginGuest::OnImeSetComposition(
selection_start, selection_end));
}
-void BrowserPluginGuest::OnImeCommitText(int browser_plugin_instance_id,
- const std::string& text,
- int relative_cursor_pos) {
+void BrowserPluginGuest::OnImeCommitText(
+ int browser_plugin_instance_id,
+ const std::string& text,
+ const std::vector<blink::WebCompositionUnderline>& underlines,
+ int relative_cursor_pos) {
Send(new InputMsg_ImeCommitText(routing_id(), base::UTF8ToUTF16(text),
- gfx::Range::InvalidRange(),
+ underlines, gfx::Range::InvalidRange(),
relative_cursor_pos));
}
« no previous file with comments | « content/browser/browser_plugin/browser_plugin_guest.h ('k') | content/browser/renderer_host/ime_adapter_android.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698