components/test_runner/text_input_controller.cc - Issue 2568093003: Support parsing BackgroundSpans and UnderlineSpans in Android IME's commitText()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/test_runner/text_input_controller.cc

Issue 2568093003: Support parsing BackgroundSpans and UnderlineSpans in Android IME's commitText() (Closed)

Patch Set: Rebase Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/test_runner/text_input_controller.cc

diff --git a/components/test_runner/text_input_controller.cc b/components/test_runner/text_input_controller.cc

index 5a94e7845ebb44d993efaf1221bb448efae3e672..05de1c83a2300f44f67dde98ab9cfe81b2cf260c 100644

--- a/components/test_runner/text_input_controller.cc

+++ b/components/test_runner/text_input_controller.cc

@@ -171,7 +171,8 @@ void TextInputController::Install(blink::WebLocalFrame* frame) {

void TextInputController::InsertText(const std::string& text) {

if (auto* controller = GetInputMethodController()) {

- controller->commitText(blink::WebString::fromUTF8(text), 0);

+ controller->commitText(blink::WebString::fromUTF8(text),

+ std::vector<blink::WebCompositionUnderline>(), 0);

}